git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Drew DeVault <sir@cmpwn.com>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] git-send-email: die if sendmail.* config is set
Date: Mon, 20 Jul 2020 13:33:36 -0400	[thread overview]
Message-ID: <20200720173336.GC2045458@coredump.intra.peff.net> (raw)
In-Reply-To: <20200718202142.111015-1-sir@cmpwn.com>

On Sat, Jul 18, 2020 at 04:21:42PM -0400, Drew DeVault wrote:

> I've seen several people mis-configure git send-email on their first
> attempt because they set the sendmail.* config options - not
> sendemail.*. This patch detects this mistake and bails out with a
> friendly warning.

This basically claims the "sendmail.*" namespace for send-email. Not
strictly, but if we're going to warn about anything set in it, it
effectively shuts out other uses.

I'm OK with that, but if we're going to do so, should we perhaps just
say "sendmail.* is an alias for sendemail.*"? Then rather than getting a
warning, this mistake would Just Work.

-Peff

  parent reply	other threads:[~2020-07-20 17:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18 20:21 Drew DeVault
2020-07-18 20:38 ` Junio C Hamano
2020-07-19  6:07   ` Junio C Hamano
2020-07-20 17:33 ` Jeff King [this message]
2020-07-20 17:40   ` Drew DeVault
2020-07-24  0:42     ` Junio C Hamano
2020-07-24  0:43       ` Drew DeVault
2020-07-24  0:59         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720173336.GC2045458@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sir@cmpwn.com \
    --subject='Re: [PATCH v2] git-send-email: die if sendmail.* config is set' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).