From: "SZEDER Gábor" <firstname.lastname@example.org> To: Junio C Hamano <email@example.com> Cc: Derrick Stolee <firstname.lastname@example.org>, email@example.com Subject: Re: sg/commit-graph-cleanups (was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6)) Date: Fri, 10 Jul 2020 23:13:42 +0200 Message-ID: <20200710211342.GE11341@szeder.dev> (raw) In-Reply-To: <firstname.lastname@example.org> On Tue, Jul 07, 2020 at 11:12:51AM -0700, Junio C Hamano wrote: > SZEDER Gábor <email@example.com> writes: > > > On Tue, Jul 07, 2020 at 09:45:21AM -0700, Junio C Hamano wrote: > >> Derrick Stolee <firstname.lastname@example.org> writes: > >> > >> >> Oops, I am not sure what happened here. There I thought were issues > >> >> pointed out at least on the latter series but was I hallucinating? > >> > > >> > I believe I have resolved all the open comments in both series. > >> > >> OK, then I do not have to be worried. > >> > >> Let's merge it down before -rc0. > > > > I think it was merged to next too soon. I haven't even done with > > reporting all the issues that were already in v2.27.0, let alone > > looking through these followup series... > > Oh, so what's your preference? Reverting all the commit-graph stuff > that is not in 2.26 may be tempting but is not practically feasible > this late in the cycle. It sounded like Derrick was OK to leave > them in 'next', and I am fine with keeping them out of the upcoming > release. Yeah, I think it's sensible to leave them out from the upcoming release, because that would give us the possibility (and me the time) to go over them once more. Glancing through it, I see that Derrick kept most of my commit messages as-is, but some of them contain forward references to later patches in my modified path Bloom filters series that don't make sense on their own. There are also some missing tests, a missing "Reported-by: me", missing updates to the format specs, and even a missing(?) patch.
next prev parent reply other threads:[~2020-07-10 21:13 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-07 5:57 What's cooking in git.git (Jul 2020, #01; Mon, 6) Junio C Hamano 2020-07-07 13:29 ` sg/commit-graph-cleanups (was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6)) Derrick Stolee 2020-07-07 15:10 ` Junio C Hamano 2020-07-07 15:12 ` Junio C Hamano 2020-07-07 16:00 ` Derrick Stolee 2020-07-07 16:45 ` Junio C Hamano 2020-07-07 16:49 ` Taylor Blau 2020-07-07 17:21 ` SZEDER Gábor 2020-07-07 18:12 ` Junio C Hamano 2020-07-10 21:13 ` SZEDER Gábor [this message] 2020-07-10 21:38 ` Junio C Hamano 2020-07-08 14:31 ` mr/bisect-in-c-2, was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6) Johannes Schindelin 2020-07-08 15:43 ` Junio C Hamano 2020-07-08 23:11 ` Junio C Hamano 2020-07-09 9:20 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200710211342.GE11341@szeder.dev \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ firstname.lastname@example.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git