From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, dstolee@microsoft.com, jayconrod@google.com,
jonathantanmy@google.com
Subject: Re: [PATCH] commit.c: don't persist substituted parents when unshallowing
Date: Wed, 8 Jul 2020 17:22:10 -0400 [thread overview]
Message-ID: <20200708212210.GA17015@syl.lan> (raw)
In-Reply-To: <xmqqk0zd20cf.fsf@gitster.c.googlers.com>
On Wed, Jul 08, 2020 at 01:55:28PM -0700, Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
> > A fairly straightforward test that demonstrates the bug being fixed and
> > only relies on what was set up in the initial 'setup' test (4 commits).
> > Thanks for tying that loose end.
> >
> > With or without commit message tweaks along the lines described above,
> > Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> >
> > Thanks for your thoughtful work, as always.
>
> Thanks for a nicely written review. It would be very nice if we can
> see a reroll before I have to tag -rc0.
Of course! I just sent one here[1]. Sorry for the last-minute addition
to -rc0, and thanks for fast-tracking it down.
> Thanks.
Thanks,
Taylor
[1]: https://lore.kernel.org/git/1f769bbbb4f1b4ad67d29ee7b3e5282446e4cc0f.1594242582.git.me@ttaylorr.com/
prev parent reply other threads:[~2020-07-08 21:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 14:42 [PATCH] commit.c: don't persist substituted parents when unshallowing Taylor Blau
2020-07-07 14:43 ` Taylor Blau
2020-07-08 21:10 ` [PATCH v2] " Taylor Blau
2020-07-09 1:00 ` Jonathan Nieder
2020-07-09 1:21 ` Junio C Hamano
2020-07-08 5:41 ` [PATCH] " Jonathan Nieder
2020-07-08 20:55 ` Junio C Hamano
2020-07-08 21:22 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708212210.GA17015@syl.lan \
--to=me@ttaylorr.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jayconrod@google.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).