From: Christian Couder <christian.couder@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH v3 0/4] Add support for %(contents:size) in ref-filter
Date: Tue, 7 Jul 2020 19:40:45 +0200 [thread overview]
Message-ID: <20200707174049.21714-1-chriscool@tuxfamily.org> (raw)
This is version 3 of a small patch series to teach ref-filter about
%(contents:size).
This patch series is based on current master.
Previous versions and related discussions are here:
V1: https://lore.kernel.org/git/20200701132308.16691-1-chriscool@tuxfamily.org/
V2: https://lore.kernel.org/git/20200702140845.24945-1-chriscool@tuxfamily.org/
Thanks to Junio and Peff for their reviews of this series!
The changes compared to V2 are the following:
- Added patch 2/4 that clarifies the meaning of "complete message"
in the doc.
- Added patch 3/4 that adds tests for refs pointing to a tree or a
blob.
- Improved commit message in patch 4/4 as suggested by Junio.
- Added %(contents:size) tests in patch 4/4 for refs pointing to a
tree or a blob.
The range diff is:
1: c6e80b8bc1 = 1: b04b390f32 Documentation: clarify %(contents:XXXX) doc
-: ---------- > 2: b62cab2630 Documentation: clarify 'complete message'
-: ---------- > 3: b9584472a1 t6300: test refs pointing to tree and blob
2: 9853b37091 ! 4: 23f941132e ref-filter: add support for %(contents:size)
@@ Commit message
Also the result of the following:
- `git for-each-ref --format='%(contents)' | wc -c`
+ `git for-each-ref --format='%(contents)' refs/heads/my-branch | wc -c`
is off by one as `git for-each-ref` appends a newline character
- after the contents, which can be seen by comparing its ouput
+ after the contents, which can be seen by comparing its output
with the output from `git cat-file`.
+ As with %(contents), %(contents:size) is silently ignored, if a
+ ref points to something other than a commit or a tag:
+
+ ```
+ $ git update-ref refs/mytrees/first HEAD^{tree}
+ $ git for-each-ref --format='%(contents)' refs/mytrees/first
+
+ $ git for-each-ref --format='%(contents:size)' refs/mytrees/first
+
+ ```
+
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
## Documentation/git-for-each-ref.txt ##
-@@ Documentation/git-for-each-ref.txt: and `date` to extract the named component.
- The complete message of a commit or tag object is `contents`. This
- field can also be used in the following ways:
+@@ Documentation/git-for-each-ref.txt: The complete message (subject, body, trailers and signature) of a
+ commit or tag object is `contents`. This field can also be used in the
+ following ways:
+contents:size::
+ The size in bytes of the complete message.
@@ t/t6300-for-each-ref.sh: test_atom refs/tags/signed-long contents "subject line
$sig"
+test_tag_contents_size_pgp refs/tags/signed-long
+ test_expect_success 'set up refs pointing to tree and blob' '
+ git update-ref refs/mytrees/first refs/heads/master^{tree} &&
+@@ t/t6300-for-each-ref.sh: test_atom refs/mytrees/first body ""
+ test_atom refs/mytrees/first contents:body ""
+ test_atom refs/mytrees/first contents:signature ""
+ test_atom refs/mytrees/first contents ""
++test_atom refs/mytrees/first contents:size ""
+
+ test_atom refs/myblobs/first subject ""
+ test_atom refs/myblobs/first contents:subject ""
+@@ t/t6300-for-each-ref.sh: test_atom refs/myblobs/first body ""
+ test_atom refs/myblobs/first contents:body ""
+ test_atom refs/myblobs/first contents:signature ""
+ test_atom refs/myblobs/first contents ""
++test_atom refs/myblobs/first contents:size ""
+
test_expect_success 'set up multiple-sort tags' '
for when in 100000 200000
Christian Couder (4):
Documentation: clarify %(contents:XXXX) doc
Documentation: clarify 'complete message'
t6300: test refs pointing to tree and blob
ref-filter: add support for %(contents:size)
Documentation/git-for-each-ref.txt | 28 +++++++++++++++-----
ref-filter.c | 7 ++++-
t/t6300-for-each-ref.sh | 41 ++++++++++++++++++++++++++++++
3 files changed, 69 insertions(+), 7 deletions(-)
--
2.27.0.460.g66f3a24dd5
next reply other threads:[~2020-07-07 17:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 17:40 Christian Couder [this message]
2020-07-07 17:40 ` [PATCH v3 1/4] Documentation: clarify %(contents:XXXX) doc Christian Couder
2020-07-07 19:26 ` Junio C Hamano
2020-07-10 16:47 ` Christian Couder
2020-07-07 17:40 ` [PATCH v3 2/4] Documentation: clarify 'complete message' Christian Couder
2020-07-07 19:19 ` Junio C Hamano
2020-07-07 17:40 ` [PATCH v3 3/4] t6300: test refs pointing to tree and blob Christian Couder
2020-07-07 19:32 ` Junio C Hamano
2020-07-07 17:40 ` [PATCH v3 4/4] ref-filter: add support for %(contents:size) Christian Couder
2020-07-07 19:45 ` Junio C Hamano
2020-07-09 0:14 ` Junio C Hamano
2020-07-09 8:10 ` Christian Couder
2020-07-09 13:47 ` Junio C Hamano
2020-07-07 22:21 ` Junio C Hamano
2020-07-08 23:05 ` Junio C Hamano
2020-07-10 16:47 ` [PATCH v4 0/3] Add support for %(contents:size) in ref-filter Christian Couder
2020-07-10 16:47 ` [PATCH v4 1/3] Documentation: clarify %(contents:XXXX) doc Christian Couder
2020-07-10 20:24 ` Junio C Hamano
2020-07-10 16:47 ` [PATCH v4 2/3] t6300: test refs pointing to tree and blob Christian Couder
2020-07-10 20:24 ` Junio C Hamano
2020-07-10 16:47 ` [PATCH v4 3/3] ref-filter: add support for %(contents:size) Christian Couder
2020-07-10 20:38 ` Junio C Hamano
2020-07-16 12:19 ` [PATCH v5 0/3] Add support for %(contents:size) in ref-filter Christian Couder
2020-07-16 12:19 ` [PATCH v5 1/3] Documentation: clarify %(contents:XXXX) doc Christian Couder
2020-07-16 12:19 ` [PATCH v5 2/3] t6300: test refs pointing to tree and blob Christian Couder
2020-07-16 12:19 ` [PATCH v5 3/3] ref-filter: add support for %(contents:size) Christian Couder
2020-07-31 17:37 ` Alban Gruin
2020-07-31 17:45 ` [PATCH v1] t6300: fix issues related to %(contents:size) Alban Gruin
2020-07-31 17:47 ` Jeff King
2020-07-31 18:24 ` Alban Gruin
2020-07-31 20:04 ` Junio C Hamano
2020-07-31 20:30 ` Jeff King
2020-07-31 18:26 ` [PATCH v2] " Alban Gruin
2020-07-31 19:15 ` Jeff King
2020-07-31 17:45 ` [PATCH v5 3/3] ref-filter: add support for %(contents:size) Jeff King
2020-07-31 20:12 ` Christian Couder
2020-07-31 20:30 ` Junio C Hamano
2020-07-31 20:40 ` Jeff King
2020-07-16 17:48 ` [PATCH v5 0/3] Add support for %(contents:size) in ref-filter Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707174049.21714-1-chriscool@tuxfamily.org \
--to=christian.couder@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).