git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Derrick Stolee <stolee@gmail.com>, git@vger.kernel.org
Subject: Re: sg/commit-graph-cleanups (was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6))
Date: Tue, 7 Jul 2020 12:49:53 -0400	[thread overview]
Message-ID: <20200707164953.GA36941@syl.lan> (raw)
In-Reply-To: <xmqqimez5l5q.fsf@gitster.c.googlers.com>

On Tue, Jul 07, 2020 at 09:45:21AM -0700, Junio C Hamano wrote:
> Derrick Stolee <stolee@gmail.com> writes:
>
> >> Oops, I am not sure what happened here.  There I thought were issues
> >> pointed out at least on the latter series but was I hallucinating?
> >
> > I believe I have resolved all the open comments in both series.
>
> OK, then I do not have to be worried.
>
> Let's merge it down before -rc0.

Stolee and I did find a few unrelated bugs with Bloom filters in the
past day or two while starting to use them at GitHub. The biggest is
that Bloom filters are not used if the top-most incremental layer does
not have Bloom data.

I'm not sure if this is a show-stopping bug or not, but if it is, I'd be
happy to send a patch or two on top before -rc0.

The other bug is less serious, which is that we do reuse Bloom data from
previous graphs even when writing a new graph with `--split=replace`.
The fix is more involved, so I'm less inclined to rush it before -rc0.

Let me know your thoughts. Thanks.

> Thanks.

Taylor

  reply	other threads:[~2020-07-07 16:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07  5:57 What's cooking in git.git (Jul 2020, #01; Mon, 6) Junio C Hamano
2020-07-07 13:29 ` sg/commit-graph-cleanups (was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6)) Derrick Stolee
2020-07-07 15:10   ` Junio C Hamano
2020-07-07 15:12   ` Junio C Hamano
2020-07-07 16:00     ` Derrick Stolee
2020-07-07 16:45       ` Junio C Hamano
2020-07-07 16:49         ` Taylor Blau [this message]
2020-07-07 17:21         ` SZEDER Gábor
2020-07-07 18:12           ` Junio C Hamano
2020-07-10 21:13             ` SZEDER Gábor
2020-07-10 21:38               ` Junio C Hamano
2020-07-08 14:31 ` mr/bisect-in-c-2, was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6) Johannes Schindelin
2020-07-08 15:43   ` Junio C Hamano
2020-07-08 23:11     ` Junio C Hamano
2020-07-09  9:20       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707164953.GA36941@syl.lan \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).