From: Trygve Aaberge <trygveaa@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff Hostetler <jeffhost@microsoft.com>,
Heba Waly <heba.waly@gmail.com>
Subject: Re: [PATCH 1/2] Wait for child on signal death for aliases to builtins
Date: Tue, 7 Jul 2020 12:23:55 +0200 [thread overview]
Message-ID: <20200707102355.2kukfzxt7vhhenfy@aaberge.net> (raw)
In-Reply-To: <xmqqwo3g6qlu.fsf@gitster.c.googlers.com>
On Mon, Jul 06, 2020 at 18:50:05 -0700, Junio C Hamano wrote:
> True, as Dscho also mentioned. I'll just do "b914084007" =>
> "ee4512ed48 and b914084007" while queueing.
I noticed that I was missing a word in the message, and I'm sending a new
patch with a better commit message for the second commit, so I'll update this
in the first commit and send a new patchset.
> > A test would be nice, but I don't think it's very feasible for the same
> > reason mentioned in 46df6906f3.
Yeah, I don't think I have a good enough grasp of how to test this, and I saw
that there wasn't any existing tests for it, so that's why I dropped it.
--
Trygve Aaberge
next prev parent reply other threads:[~2020-07-07 10:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 22:18 [PATCH 1/2] Wait for child on signal death for aliases to builtins trygveaa
2020-07-04 22:18 ` [PATCH 2/2] Wait for child on signal death for aliases to externals trygveaa
2020-07-06 21:14 ` Jeff King
2020-07-07 1:38 ` Junio C Hamano
2020-07-07 10:19 ` Trygve Aaberge
2020-07-07 22:06 ` Jeff King
2020-07-05 2:15 ` [PATCH 1/2] Wait for child on signal death for aliases to builtins Johannes Schindelin
2020-07-07 1:48 ` Junio C Hamano
2020-07-06 20:41 ` Jeff King
2020-07-07 1:50 ` Junio C Hamano
2020-07-07 10:23 ` Trygve Aaberge [this message]
2020-07-07 12:17 ` [PATCH v2 " trygveaa
2020-07-07 12:17 ` [PATCH v2 2/2] Wait for child on signal death for aliases to externals trygveaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707102355.2kukfzxt7vhhenfy@aaberge.net \
--to=trygveaa@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=heba.waly@gmail.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).