From: Miriam Rubio <mirucam@gmail.com>
To: git@vger.kernel.org
Cc: Miriam Rubio <mirucam@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH v4 01/13] bisect--helper: BUG() in cmd_*() on invalid subcommand
Date: Wed, 1 Jul 2020 15:34:52 +0200 [thread overview]
Message-ID: <20200701133504.18360-2-mirucam@gmail.com> (raw)
In-Reply-To: <20200701133504.18360-1-mirucam@gmail.com>
In cmd_bisect__helper() function, there would be a bug
if an invalid or no subcommand was passed.return error()
should be replaced by BUG() in that case.
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
builtin/bisect--helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index ec4996282e..c452d3f6b7 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -716,7 +716,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
res = bisect_start(&terms, no_checkout, argv, argc);
break;
default:
- return error("BUG: unknown subcommand '%d'", cmdmode);
+ BUG("unknown subcommand %d", (int)cmdmode);
}
free_terms(&terms);
--
2.25.0
next prev parent reply other threads:[~2020-07-01 13:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 13:34 [PATCH v4 00/13] Finish converting git bisect to C part 2 Miriam Rubio
2020-07-01 13:34 ` Miriam Rubio [this message]
2020-07-01 13:34 ` [PATCH v4 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return Miriam Rubio
2020-07-01 13:34 ` [PATCH v4 03/13] bisect--helper: introduce new `write_in_file()` function Miriam Rubio
2020-07-01 14:56 ` Chris Torek
2020-07-08 19:52 ` Junio C Hamano
2020-07-01 13:34 ` [PATCH v4 04/13] bisect--helper: reimplement `bisect_autostart` shell function in C Miriam Rubio
2020-07-01 13:34 ` [PATCH v4 05/13] bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()' Miriam Rubio
2020-07-01 13:34 ` [PATCH v4 06/13] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C Miriam Rubio
2020-07-01 13:34 ` [PATCH v4 07/13] bisect--helper: finish porting `bisect_start()` to C Miriam Rubio
2020-07-01 13:34 ` [PATCH v4 08/13] bisect--helper: retire `--bisect-clean-state` subcommand Miriam Rubio
2020-07-01 13:35 ` [PATCH v4 09/13] bisect--helper: retire `--next-all` subcommand Miriam Rubio
2020-07-01 13:35 ` [PATCH v4 10/13] bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C Miriam Rubio
2020-07-08 21:38 ` Junio C Hamano
2020-07-01 13:35 ` [PATCH v4 11/13] bisect--helper: retire `--check-expected-revs` subcommand Miriam Rubio
2020-07-01 13:35 ` [PATCH v4 12/13] bisect--helper: retire `--write-terms` subcommand Miriam Rubio
2020-07-01 13:35 ` [PATCH v4 13/13] bisect--helper: retire `--bisect-autostart` subcommand Miriam Rubio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701133504.18360-2-mirucam@gmail.com \
--to=mirucam@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).