From: "brian m. carlson" <email@example.com> To: Matheus Tavares Bernardino <firstname.lastname@example.org> Cc: git <email@example.com>, Johannes Sixt <firstname.lastname@example.org>, Jeff King <email@example.com>, Jonathan Tan <firstname.lastname@example.org> Subject: Re: [RFC] Thread safety in some low-level functions Date: Thu, 25 Jun 2020 01:38:51 +0000 [thread overview] Message-ID: <20200625013851.GA9782@camp.crustytoothpaste.net> (raw) In-Reply-To: <CAHd-oW5jCWeWDcMhLU2Zf96uTtxLehVsM+StDC8LZga282cDjw@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1606 bytes --] On 2020-06-24 at 22:52:58, Matheus Tavares Bernardino wrote: > On Wed, Jun 24, 2020 at 7:29 PM Matheus Tavares Bernardino > <email@example.com> wrote: > > > > - Regarding, oid_to_hex(), a patch from 2010  proposed a solution > > using thread-local storage and pthread_once(). But as Hannes pointed > > out in this other thread  , implementing a Windows equivalence for > > pthread_once() could be tricky and voluminous. Since this thread dates > > from 7 years ago, I was wondering if we would be able to implement it > > nowadays with InitOnceExecuteOnce() . > > I forgot to link it before, but here is a commit in libav.git which > emulates pthread_once(): > https://git.libav.org/?p=libav.git;a=commitdiff;h=b22693b06d1e5d73454a65c203b4d31c1ca5b69a > > The patch is not so big, and if we consider only Vista+, it seems very > straightforward. I'm not very familiar with Windows, though, and I'm > not sure if this solution would work for us. I believe Git for Windows dropped support for Windows XP some time back. Regardless, since pretty much nobody using Windows XP (with the possible exception of ATMs) is getting security support, I'm fine with ignoring it either way. I am also not a Windows person, so others may have more insight. As for the general idea, I'm mildly in favor of it. While I don't plan to work on the project myself (outside of cleaning up places I'm already working), I'm definitely not opposed to seeing patches come in to improve thread safety. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2020-06-25 1:39 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-24 22:29 Matheus Tavares Bernardino 2020-06-24 22:52 ` Matheus Tavares Bernardino 2020-06-25 1:38 ` brian m. carlson [this message] 2020-06-25 20:32 ` [PATCH 0/2] Make oid_to_hex() thread-safe Matheus Tavares 2020-06-25 20:32 ` [PATCH 1/2] compat/win32/pthread: add pthread_once() Matheus Tavares 2020-06-26 5:45 ` Christian Couder 2020-06-26 14:13 ` Matheus Tavares Bernardino 2020-06-25 20:32 ` [PATCH 2/2] hex: make hash_to_hex_algop() and friends thread-safe Matheus Tavares 2020-06-25 23:07 ` brian m. carlson 2020-06-25 23:54 ` Matheus Tavares Bernardino 2020-06-26 0:00 ` Matheus Tavares Bernardino 2020-06-26 6:02 ` Christian Couder 2020-06-26 8:22 ` [PATCH 0/2] Make oid_to_hex() thread-safe Christian Couder 2020-06-26 16:22 ` Matheus Tavares Bernardino 2020-06-26 21:54 ` [PATCH v2 " Matheus Tavares 2020-06-26 21:54 ` [PATCH v2 1/2] compat/win32/pthread: add pthread_once() Matheus Tavares 2020-06-26 21:54 ` [PATCH v2 2/2] hex: make hash_to_hex_algop() and friends thread-safe Matheus Tavares 2020-06-29 15:11 ` Johannes Schindelin 2020-06-30 20:37 ` Matheus Tavares Bernardino 2020-07-01 11:32 ` Johannes Schindelin 2020-07-16 11:29 ` Johannes Schindelin 2020-07-18 3:09 ` Matheus Tavares Bernardino 2020-08-10 14:15 ` Johannes Schindelin 2020-07-18 3:52 ` Matheus Tavares 2020-07-26 17:41 ` René Scharfe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200625013851.GA9782@camp.crustytoothpaste.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [RFC] Thread safety in some low-level functions' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).