From: Eric Sunshine <sunshine@sunshineco.com>
To: git@vger.kernel.org
Cc: Duy Nguyen <pclouds@gmail.com>, Eric Sunshine <sunshine@sunshineco.com>
Subject: [PATCH 0/2] drop specialized knowledge from generic worktree code
Date: Fri, 19 Jun 2020 19:35:42 -0400 [thread overview]
Message-ID: <20200619233544.42025-1-sunshine@sunshineco.com> (raw)
This patch series removes specialized knowledge from the libified
worktree code about how front-end "git worktree list" wants worktrees
sorted, and instead makes it the responsibility of "git worktree list"
itself to do the sorting.
It is built atop es/worktree-duplicate-paths since that series adds
another caller of get_worktrees() which this series touches.
A possible argument against this patch series is that some other entity
may someday want worktrees sorted in the same fashion as "git worktree
list", however, that seems a case of YAGNI.
Eric Sunshine (2):
worktree: drop get_worktrees() special-purpose sorting option
worktree: drop get_worktrees() unused 'flags' argument
branch.c | 2 +-
builtin/branch.c | 2 +-
builtin/config.c | 2 +-
builtin/fsck.c | 2 +-
builtin/reflog.c | 2 +-
builtin/worktree.c | 32 ++++++++++++++++++++++++++------
ref-filter.c | 2 +-
revision.c | 4 ++--
t/helper/test-ref-store.c | 2 +-
worktree.c | 20 +++-----------------
worktree.h | 11 +++--------
11 files changed, 41 insertions(+), 40 deletions(-)
--
2.27.0.221.g4d328a12d9
next reply other threads:[~2020-06-19 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 23:35 Eric Sunshine [this message]
2020-06-19 23:35 ` [PATCH 1/2] worktree: drop get_worktrees() special-purpose sorting option Eric Sunshine
2020-06-19 23:35 ` [PATCH 2/2] worktree: drop get_worktrees() unused 'flags' argument Eric Sunshine
2020-06-22 17:34 ` [PATCH 0/2] drop specialized knowledge from generic worktree code Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619233544.42025-1-sunshine@sunshineco.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).