From: Max Resnick <max.resnick@forgerock.com>
To: git@vger.kernel.org
Subject: name-ref on annotated-tags is null terminated, but lightweight tags arent
Date: Fri, 5 Jun 2020 09:51:09 -0700 [thread overview]
Message-ID: <20200605165109.jr6mjl6xz7upofdy@forgemax.local> (raw)
Thank you for filling out a Git bug report!
Please answer the following questions to help us understand your issue.
What did you do before the bug happened? (Steps to reproduce your issue)
I was using name-rev to resolve a commits tag name. Annotated tags seem
to have a null termination and lightweight tags dont.
```
/tmp
❯ git clone https://github.com/maxres-fr/null-termination-issue.git
Cloning into 'null-termination-issue'...
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 10 (delta 0), reused 10 (delta 0), pack-reused 0
Unpacking objects: 100% (10/10), 757 bytes | 189.00 KiB/s, done.
/tmp
❯ cd null-termination-issue
/tmp/null-termination-issue on master
❯ git pull --tags
Already up to date.
/tmp/null-termination-issue on master
❯ git tag --list
/tmp/null-termination-issue on master
❯ git name-rev --tag --name-only
38bdebc9107cab4ab3718d0581632702e74d9209
annotated-tag^0
/tmp/null-termination-issue on master
❯ git name-rev --tag --name-only
a340894d3ee655ae6c336a85b42d2215d52609e3
lightweight-tag
```
What did you expect to happen? (Expected behavior)
`git name-rev --tag --name-only ANNOTATED-COMMIT-ID` to return the name
without null termination
What happened instead? (Actual behavior)
`git name-rev --tag --name-only ANNOTATED-COMMIT-ID` returns the name
but it's null terminated
What's different between what you expected and what actually happened?
a null control character exists.
Anything else you want to add:
I tried this with the following git versions:
2.11, 2.23, 2.26, 2.27. I've also been able to reproduce on MacOS.
Please review the rest of the bug report below.
You can delete any lines you don't wish to share.
[System Info]
git version:
git version 2.27.0.rc0
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
uname: Linux 5.6.0-1-amd64 #1 SMP Debian 5.6.7-1 (2020-04-29) x86_64
compiler info: gnuc: 9.3
libc info: glibc: 2.30
[Enabled Hooks]
next reply other threads:[~2020-06-05 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 16:51 Max Resnick [this message]
2020-06-05 17:04 ` name-ref on annotated-tags is null terminated, but lightweight tags arent Junio C Hamano
2020-06-05 17:16 ` Max Resnick
2020-06-05 17:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605165109.jr6mjl6xz7upofdy@forgemax.local \
--to=max.resnick@forgerock.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).