From: Laurent Arnoud <laurent@spkdev.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] format-patch: generate valid patch with diff.noprefix config
Date: Thu, 4 Jun 2020 21:32:38 +0200 [thread overview]
Message-ID: <20200604193238.GA1911544@spk-laptop> (raw)
In-Reply-To: <xmqqeeqxrufz.fsf@gitster.c.googlers.com>
On Tue, Jun 02, 2020 at 03:09:36PM -0700, Junio C Hamano wrote:
> Having said all that, we seem to be letting more configurations for
> the diff.* family to affect the format-patch command. The latest
> addition was "diff.relative"---together with the "diff.noprefix"
> that triggered this thread, some users may feel that it is a bug to
> allow these configuration variables to affect the output from the
> "log -p", "show", and "format-patch" commands.
>
> It *might* make sense to introduce log.diff.* configuration
> variables so that when they are set, they are used by
> log/show/format-patch instead of diff.* counterparts, or something
> along those lines. I dunno.
I don't know if its a bug but I founded strange that I needed to use an alias
"git -c diff.noprefix=false format-patch" to generate a patch that I can apply
directly with "git am". I didn't know the -p option but to send a patch to a
mailinglist it should have the prefix I guess ?
I can try to implement this option if you think it can get merged
--
Laurent
next prev parent reply other threads:[~2020-06-04 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 20:49 [PATCH] format-patch: generate valid patch with diff.noprefix config Laurent Arnoud
2020-06-02 21:12 ` Junio C Hamano
2020-06-02 21:33 ` Laurent Arnoud
2020-06-02 22:09 ` Junio C Hamano
2020-06-04 19:32 ` Laurent Arnoud [this message]
2020-06-04 20:18 ` Junio C Hamano
2020-06-04 23:26 ` Đoàn Trần Công Danh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604193238.GA1911544@spk-laptop \
--to=laurent@spkdev.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).