From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 76B241F55B for ; Fri, 22 May 2020 15:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730597AbgEVPyM (ORCPT ); Fri, 22 May 2020 11:54:12 -0400 Received: from cloud.peff.net ([104.130.231.41]:54478 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730137AbgEVPyL (ORCPT ); Fri, 22 May 2020 11:54:11 -0400 Received: (qmail 21446 invoked by uid 109); 22 May 2020 15:54:11 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 22 May 2020 15:54:11 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 7143 invoked by uid 111); 22 May 2020 15:54:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 22 May 2020 11:54:11 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 22 May 2020 11:54:10 -0400 From: Jeff King To: Denton Liu Cc: Git Mailing List , Eric Sunshine , Junio C Hamano Subject: Re: [PATCH v3 9/9] fixup! remote-curl: error on incomplete packet Message-ID: <20200522155410.GA2146293@coredump.intra.peff.net> References: <4364b38bd027c219d41282bad3f8476daec936f9.1590154401.git.liu.denton@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4364b38bd027c219d41282bad3f8476daec936f9.1590154401.git.liu.denton@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, May 22, 2020 at 09:33:47AM -0400, Denton Liu wrote: > In the CGI scripts which emulate a connection being prematurely > terminated, it doesn't make sense for there to be a trailing newline > after the simulated connection cut. Remove these newlines. Ah, good catch. I think in the first one it doesn't matter: > -printf "%s%s\n" "0079" "45" > +printf "%s%s" "0079" "45" because we have a too-short packet, so the fact that it is 3 bytes and not 2 does not change that. I agree it's clearer without the newline, though. I wonder if: printf "0079" "fewer than 0x79 bytes" would make it even more self-documenting. :) > -printf "%s\n" "00" > +printf "%s" "00" This one is a behavior improvement: we were probably hitting "oops, newline isn't a valid line-length character" before, and now we're really hitting the truncated packet. I don't know if it's worth adding an extra test with a bogus line-length. I'm OK with with it either way. -Peff