git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
* [PATCH] doc: fix wrong 4-byte length of pkt-line message
@ 2020-05-21  7:56 Jiuyang Xie
  2020-05-21  9:44 ` Denton Liu
  0 siblings, 1 reply; 5+ messages in thread
From: Jiuyang Xie @ 2020-05-21  7:56 UTC (permalink / raw)
  To: Junio C Hamano, Git List; +Cc: Jiuyang Xie

The first four bytes of the line, the pkt-len, indicates the total
length of the pkt-line in hexadecimal.  Fixed wrong pkt-len headers of
some pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.

Signed-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>
---
 Documentation/technical/http-protocol.txt | 2 +-
 Documentation/technical/pack-protocol.txt | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt
index 9c5b6f0fac..51a79e63de 100644
--- a/Documentation/technical/http-protocol.txt
+++ b/Documentation/technical/http-protocol.txt
@@ -216,7 +216,7 @@ smart server reply:
    S: 001e# service=git-upload-pack\n
    S: 0000
    S: 004895dcfa3633004da0049d3d0fa03f80589cbcaf31 refs/heads/maint\0multi_ack\n
-   S: 0042d049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\n
+   S: 003fd049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\n
    S: 003c2cb58b79488a98d2721cea644875a8dd0026b115 refs/tags/v1.0\n
    S: 003fa3c2e2402b99163d1d59756e5f207ae21cccba4c refs/tags/v1.0^{}\n
    S: 0000
diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
index d5ce4eea8a..a4573d12ce 100644
--- a/Documentation/technical/pack-protocol.txt
+++ b/Documentation/technical/pack-protocol.txt
@@ -96,7 +96,7 @@ Basically what the Git client is doing to connect to an 'upload-pack'
 process on the server side over the Git protocol is this:
 
    $ echo -e -n \
-     "0039git-upload-pack /schacon/gitbook.git\0host=example.com\0" |
+     "003agit-upload-pack /schacon/gitbook.git\0host=example.com\0" |
      nc -v example.com 9418
 
 
@@ -171,9 +171,9 @@ with a version number (if "version=1" is sent as an Extra Parameter),
 and a listing of each reference it has (all branches and tags) along
 with the object name that each reference currently points to.
 
-   $ echo -e -n "0044git-upload-pack /schacon/gitbook.git\0host=example.com\0\0version=1\0" |
+   $ echo -e -n "0045git-upload-pack /schacon/gitbook.git\0host=example.com\0\0version=1\0" |
       nc -v example.com 9418
-   000aversion 1
+   000eversion 1
    00887217a7c7e582c46cec22a130adf4b9d7d950fba0 HEAD\0multi_ack thin-pack
 		side-band side-band-64k ofs-delta shallow no-progress include-tag
    00441d3fcd5ced445d1abc402225c0b8a1299641f497 refs/heads/integration
-- 
2.25.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] doc: fix wrong 4-byte length of pkt-line message
  2020-05-21  7:56 [PATCH] doc: fix wrong 4-byte length of pkt-line message Jiuyang Xie
@ 2020-05-21  9:44 ` Denton Liu
  2020-05-21 10:41   ` [PATCH v2] " Jiuyang Xie
  0 siblings, 1 reply; 5+ messages in thread
From: Denton Liu @ 2020-05-21  9:44 UTC (permalink / raw)
  To: Jiuyang Xie; +Cc: Junio C Hamano, Git List, Jiuyang Xie

Hi Jiuyang,

On Thu, May 21, 2020 at 03:56:43PM +0800, Jiuyang Xie wrote:
> The first four bytes of the line, the pkt-len, indicates the total
> length of the pkt-line in hexadecimal.  Fixed wrong pkt-len headers of

s/Fixed/Fix/ perhaps?

> some pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.
> 
> Signed-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>

Aside from the above, I manually checked all of the changes and they
look good to me.

-Denton

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] doc: fix wrong 4-byte length of pkt-line message
  2020-05-21  9:44 ` Denton Liu
@ 2020-05-21 10:41   ` Jiuyang Xie
  2020-05-21 11:21     ` Denton Liu
  0 siblings, 1 reply; 5+ messages in thread
From: Jiuyang Xie @ 2020-05-21 10:41 UTC (permalink / raw)
  To: Junio C Hamano, Git List; +Cc: Jiuyang Xie, Denton Liu

The first four bytes of the line, the pkt-len, indicates the total
length of the pkt-line in hexadecimal. Fix wrong pkt-len headers of
some pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.

Reviewd-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>
---
 Documentation/technical/http-protocol.txt | 2 +-
 Documentation/technical/pack-protocol.txt | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt
index 9c5b6f0fac..51a79e63de 100644
--- a/Documentation/technical/http-protocol.txt
+++ b/Documentation/technical/http-protocol.txt
@@ -216,7 +216,7 @@ smart server reply:
    S: 001e# service=git-upload-pack\n
    S: 0000
    S: 004895dcfa3633004da0049d3d0fa03f80589cbcaf31 refs/heads/maint\0multi_ack\n
-   S: 0042d049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\n
+   S: 003fd049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\n
    S: 003c2cb58b79488a98d2721cea644875a8dd0026b115 refs/tags/v1.0\n
    S: 003fa3c2e2402b99163d1d59756e5f207ae21cccba4c refs/tags/v1.0^{}\n
    S: 0000
diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
index d5ce4eea8a..a4573d12ce 100644
--- a/Documentation/technical/pack-protocol.txt
+++ b/Documentation/technical/pack-protocol.txt
@@ -96,7 +96,7 @@ Basically what the Git client is doing to connect to an 'upload-pack'
 process on the server side over the Git protocol is this:
 
    $ echo -e -n \
-     "0039git-upload-pack /schacon/gitbook.git\0host=example.com\0" |
+     "003agit-upload-pack /schacon/gitbook.git\0host=example.com\0" |
      nc -v example.com 9418
 
 
@@ -171,9 +171,9 @@ with a version number (if "version=1" is sent as an Extra Parameter),
 and a listing of each reference it has (all branches and tags) along
 with the object name that each reference currently points to.
 
-   $ echo -e -n "0044git-upload-pack /schacon/gitbook.git\0host=example.com\0\0version=1\0" |
+   $ echo -e -n "0045git-upload-pack /schacon/gitbook.git\0host=example.com\0\0version=1\0" |
       nc -v example.com 9418
-   000aversion 1
+   000eversion 1
    00887217a7c7e582c46cec22a130adf4b9d7d950fba0 HEAD\0multi_ack thin-pack
 		side-band side-band-64k ofs-delta shallow no-progress include-tag
    00441d3fcd5ced445d1abc402225c0b8a1299641f497 refs/heads/integration
-- 
2.25.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] doc: fix wrong 4-byte length of pkt-line message
  2020-05-21 10:41   ` [PATCH v2] " Jiuyang Xie
@ 2020-05-21 11:21     ` Denton Liu
  2020-05-21 11:32       ` [PATCH v3] " Jiuyang Xie
  0 siblings, 1 reply; 5+ messages in thread
From: Denton Liu @ 2020-05-21 11:21 UTC (permalink / raw)
  To: Jiuyang Xie; +Cc: Junio C Hamano, Git List, Jiuyang Xie

Hi Jiuyang,

Sorry, one more small typo.

On Thu, May 21, 2020 at 06:41:46PM +0800, Jiuyang Xie wrote:
> The first four bytes of the line, the pkt-len, indicates the total
> length of the pkt-line in hexadecimal. Fix wrong pkt-len headers of
> some pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.
> 
> Reviewd-by: Denton Liu <liu.denton@gmail.com>

s/Reviewd/Reviewed/

Thanks,

Denton

> Signed-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3] doc: fix wrong 4-byte length of pkt-line message
  2020-05-21 11:21     ` Denton Liu
@ 2020-05-21 11:32       ` Jiuyang Xie
  0 siblings, 0 replies; 5+ messages in thread
From: Jiuyang Xie @ 2020-05-21 11:32 UTC (permalink / raw)
  To: Junio C Hamano, Git List; +Cc: Jiuyang Xie, Denton Liu

The first four bytes of the line, the pkt-len, indicates the total
length of the pkt-line in hexadecimal. Fix wrong pkt-len headers of
some pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.

Reviewed-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>
---
 Documentation/technical/http-protocol.txt | 2 +-
 Documentation/technical/pack-protocol.txt | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt
index 9c5b6f0fac..51a79e63de 100644
--- a/Documentation/technical/http-protocol.txt
+++ b/Documentation/technical/http-protocol.txt
@@ -216,7 +216,7 @@ smart server reply:
    S: 001e# service=git-upload-pack\n
    S: 0000
    S: 004895dcfa3633004da0049d3d0fa03f80589cbcaf31 refs/heads/maint\0multi_ack\n
-   S: 0042d049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\n
+   S: 003fd049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\n
    S: 003c2cb58b79488a98d2721cea644875a8dd0026b115 refs/tags/v1.0\n
    S: 003fa3c2e2402b99163d1d59756e5f207ae21cccba4c refs/tags/v1.0^{}\n
    S: 0000
diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
index d5ce4eea8a..a4573d12ce 100644
--- a/Documentation/technical/pack-protocol.txt
+++ b/Documentation/technical/pack-protocol.txt
@@ -96,7 +96,7 @@ Basically what the Git client is doing to connect to an 'upload-pack'
 process on the server side over the Git protocol is this:
 
    $ echo -e -n \
-     "0039git-upload-pack /schacon/gitbook.git\0host=example.com\0" |
+     "003agit-upload-pack /schacon/gitbook.git\0host=example.com\0" |
      nc -v example.com 9418
 
 
@@ -171,9 +171,9 @@ with a version number (if "version=1" is sent as an Extra Parameter),
 and a listing of each reference it has (all branches and tags) along
 with the object name that each reference currently points to.
 
-   $ echo -e -n "0044git-upload-pack /schacon/gitbook.git\0host=example.com\0\0version=1\0" |
+   $ echo -e -n "0045git-upload-pack /schacon/gitbook.git\0host=example.com\0\0version=1\0" |
       nc -v example.com 9418
-   000aversion 1
+   000eversion 1
    00887217a7c7e582c46cec22a130adf4b9d7d950fba0 HEAD\0multi_ack thin-pack
 		side-band side-band-64k ofs-delta shallow no-progress include-tag
    00441d3fcd5ced445d1abc402225c0b8a1299641f497 refs/heads/integration
-- 
2.25.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21  7:56 [PATCH] doc: fix wrong 4-byte length of pkt-line message Jiuyang Xie
2020-05-21  9:44 ` Denton Liu
2020-05-21 10:41   ` [PATCH v2] " Jiuyang Xie
2020-05-21 11:21     ` Denton Liu
2020-05-21 11:32       ` [PATCH v3] " Jiuyang Xie

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git