From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 313FB1F55B for ; Mon, 18 May 2020 16:04:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728045AbgERQE1 (ORCPT ); Mon, 18 May 2020 12:04:27 -0400 Received: from cloud.peff.net ([104.130.231.41]:49690 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727777AbgERQE0 (ORCPT ); Mon, 18 May 2020 12:04:26 -0400 Received: (qmail 20317 invoked by uid 109); 18 May 2020 16:04:26 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 18 May 2020 16:04:26 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 3436 invoked by uid 111); 18 May 2020 16:04:26 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 18 May 2020 12:04:26 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 18 May 2020 12:04:25 -0400 From: Jeff King To: Denton Liu Cc: Git Mailing List , Eric Sunshine Subject: Re: [PATCH v2 4/7] pkt-line: extern packet_length() Message-ID: <20200518160425.GA42240@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, May 18, 2020 at 11:47:21AM -0400, Denton Liu wrote: > In a future commit, we will be manually processing packets and we will > need to access the length header. In order to simplify this, extern > packet_length() so that the logic can be reused. > > Change the function parameter from a `const char *` to > `const char linelen[4]`. Even though these two types behave identically > as function parameters, use the array notation to semantically indicate > exactly what this function is expecting as an argument. OK. I double-checked that we will not run into any problems with passing pointers or arrays of other sizes (sadly compilers would not tell us if we passed a too-small array, but at least it's documented for humans). > +/* > + * Convert a four hex digit packet line length header into its numeric > + * representation. linelen should not be null-terminated. Minor nit, but it is perfectly fine if there is a NUL. Maybe "linelen does not need to be..."? -Peff