On 2020-05-16 at 11:03:56, Martin Ågren wrote: > On Wed, 13 May 2020 at 02:56, brian m. carlson > wrote: > > > > When we're checking the repository's format, set the hash algorithm at > > the same time. This ensures that we perform a suitable initialization > > early enough to avoid confusing any parts of the code. If we defer > > until later, we can end up with portions of the code which are confused > > about the hash algorithm, resulting in segfaults. > > This doesn't make a difference as long as you just use SHA-1, right? > That is, this isn't a bug in the first half of this series nor in > v2.27-rc0 as long as you stick to SHA-1? Correct, because the default is SHA-1 if no algorithm is specified. I'll update the commit message to reflect that this affects only SHA-256. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204