From: Jeff King <peff@peff.net>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, congdanhqx@gmail.com,
cbailey32@bloomberg.net, l.s.r@web.de
Subject: Re: [PATCH] compat: remove gmtime
Date: Thu, 14 May 2020 18:12:02 -0400 [thread overview]
Message-ID: <20200514221202.GB3074610@coredump.intra.peff.net> (raw)
In-Reply-To: <20200514191854.55231-1-carenas@gmail.com>
On Thu, May 14, 2020 at 12:18:54PM -0700, Carlo Marcelo Arenas Belón wrote:
> ccd469450a (date.c: switch to reentrant {gm,local}time_r, 2019-11-28)
> removes the only gmtime() call we had and moves to gmtime_r() which
> doesn't have the same portability problems.
>
> Remove the compat gmtime code since it is no longer needed, and confirm
> by successfull running t4212 in FreeBSD 9.3 amd64 (the oldest I could
> get a hold off).
So gmtime_r() behaves differently than gmtime() on those systems in the
face of an overflowing time_t? That seems like an odd implementation
choice, but OK. If the test isn't failing, I'm just as happy to get rid
of this compat cruft.
-Peff
prev parent reply other threads:[~2020-05-14 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 19:18 [PATCH] compat: remove gmtime Carlo Marcelo Arenas Belón
2020-05-14 22:12 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514221202.GB3074610@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=carenas@gmail.com \
--cc=cbailey32@bloomberg.net \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).