Re: git-gui patch staging errors

[Pratyush Yadav <me@yadavpratyush.com>]

Hi,

On 11/05/20 06:07PM, J. Paul Reed wrote:
> 
> Hey all,
> 
> I ran into an interesting problem this week where git gui was erroring out
> on staging partial patches in a particular file I was working on.
> 
> I worked around it with "git add -i," which worked like a champ.
> 
> I later realized the source file has some special characters (Unicode,
> probably) in it to print emojis (or colors or whatever fun animations the
> kids want on their terminals these days).
> 
> Interestingly, lines/hunks before the first Unicode character will
> partial-stage appropriately, but attempting to stage any hunks/lines after
> the characters produces a "Failed to stage selected line. error: patch
> failed ... error: ... patch does not apply" error dialog.
> 
> This can be reproduced by cloning
> https://github.com/debek/aws-glacier-multipart-upload.git and editing
> glacierupload.sh; the special characters are in echo statements on lines
> 60, 74, and 97.

I can't reproduce it. I cloned the repo and then edited the file at line 
60 with a diff that looks something like:

  diff --git a/glacierupload.sh b/glacierupload.sh
  index 3b956c7..265349b 100755
  --- a/glacierupload.sh
  +++ b/glacierupload.sh
  @@ -57,7 +57,9 @@ fi
   
   # count the number of files that begin with "$prefix"
   fileCount=$(ls -1 | grep "^$prefix" | wc -l)
  -echo "📦 Glacier Upload with $AWS_PROFILE"
  +bar
  +echo "📦 Glacier s Upload with $AWS_PROFILE"
  +foo
   echo "Total parts to upload: " $fileCount
   
   # get the list of part files to upload.  Edit this if you chose a different prefix in the split command

I tried a bunch of combinations if partially staging parts of this diff, 
but everything worked fine without any error message. The emoji didn't 
render properly (though that might be my font's problem), but there were 
no problems in partial staging or unstaging.

Does this example work fine on your system or does it error out? Could 
you give an example diff where git-gui has problems while staging? Maybe 
something in your config is different?
 
> Removing these control characters seems to calm git gui's indigestion on
> this file.
> 
> [preed@underworld ~]$ git --version
> git version 2.26.2
> [preed@underworld ~]$ git gui --version
> git-gui version 0.21.0.66.ga5728
> 
> best,
> preed

-- 
Regards,
Pratyush Yadav