From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 666781F8C1 for ; Thu, 7 May 2020 11:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbgEGLsw (ORCPT ); Thu, 7 May 2020 07:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbgEGLsw (ORCPT ); Thu, 7 May 2020 07:48:52 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65332C05BD43 for ; Thu, 7 May 2020 04:48:52 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id l25so2722648pgc.5 for ; Thu, 07 May 2020 04:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nqpUO0Yw8Qz3sgyY/BsJ7w/dSo9dm+MuZUuclLk7vAU=; b=RH/ZhtwYDHlO0JWpT9Ro0isz3l9fPjvRe74v7yB+AZc5twrZZpsqmn/NXy/AVofw29 rRenGfLl2ddH5K6Z1Qk2eIMWzeSlMfZ5jvmKTVJSnLKZsabqakF4ci2FNF/HuLv3rDYj Wwt9nkEIOe9QPo8ISCj9+KsMoGDz790/a/t9+C3hxD0sKF6cY6WMS0haYPw7HIdOqJBK +jsjEifUUaIxPPONw884vbOzwzf/1JXsLHZT2pOhu/DaLguCzq8DPe+yygyE2UwlPhqi 8U1jJUXqexU4Ay+Q/3TogRdJ8igrCRf52qVKYqHPqqdBrYIry8+TDr4+YK187yXYibPB SqBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nqpUO0Yw8Qz3sgyY/BsJ7w/dSo9dm+MuZUuclLk7vAU=; b=W6Y7gOK2CzNkpKpil6NtPvWWTcvRJGVS510wg9+p/oaHiINUQlMh2VRe47kukSKm61 jXJlA3njTYW1+Zq8wAbXBfskqog9Nadxd82FjrZc3x+ZsGciXs4yoPTfMvjmblIJviTO IcvHt3P0TT74ZEEerUVFl79r3waOuY0n5XmiYNTvidyOQlv+x3OMGL2QCphP2GN9BQOG wJ6c+gpmwbvDjzOi2U8dY4EdAujK3qdCuck6fGMYe2ap/Ud4WuA8NDJ8eBz3wURDuhXY 5EI/QzSXaT6CpXSEdiRW3EG+JvdjtMKZOPb64KkP6STkLyK+4Bu/Fo/1NZP+6KPhTaXq lw1g== X-Gm-Message-State: AGi0PuaF1jtrohyzlDtajUpBrTG3V/MYclM1Zp4bhSxtCJFTbP04TMbI 51P1CJlL52nrMsUApVmiRUmLrH4p X-Google-Smtp-Source: APiQypJvNym9dLoU27v16gs9HRDWwNr5w8kD4q0F3j2/Y08+rgs0eVgcANCrkwrXFe5KAWE1pkDp3g== X-Received: by 2002:a62:ae0f:: with SMTP id q15mr12857059pff.181.1588852131954; Thu, 07 May 2020 04:48:51 -0700 (PDT) Received: from localhost ([2402:800:6374:cedc:d509:3e82:1f34:e3c4]) by smtp.gmail.com with ESMTPSA id c4sm3699979pga.73.2020.05.07.04.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 04:48:51 -0700 (PDT) Date: Thu, 7 May 2020 18:48:48 +0700 From: =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh To: Sibi Siddharthan Cc: Junio C Hamano , Konstantin Tokarev , Johannes Schindelin , Jeff King , Sibi Siddharthan via GitGitGadget , "git@vger.kernel.org" Subject: Re: [PATCH 0/8] CMake build system for git Message-ID: <20200507114848.GA32465@danh.dev> References: <689741588534833@mail.yandex.ru> <848941588629532@mail.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 2020-05-07 00:13:25+0530, Sibi Siddharthan wrote: > On Tue, May 5, 2020 at 11:47 PM Junio C Hamano wrote: > > > > Sibi Siddharthan writes: > > > > > I have made the following changes as suggested: > > > 1) The CMake script works from contrib/cmake now. > I am confused for 1 though. > I think it would be better to add it as a new commit (between 7/8 and 8/8). > Is this acceptable? Please make CMake works from contrib/cmake from the first patch in the series. -- Danh