From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C9ECA1F8C1 for ; Thu, 7 May 2020 11:46:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726625AbgEGLqc (ORCPT ); Thu, 7 May 2020 07:46:32 -0400 Received: from cloud.peff.net ([104.130.231.41]:40022 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1725903AbgEGLqb (ORCPT ); Thu, 7 May 2020 07:46:31 -0400 Received: (qmail 30975 invoked by uid 109); 7 May 2020 11:46:31 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 07 May 2020 11:46:31 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 16171 invoked by uid 111); 7 May 2020 11:46:33 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 07 May 2020 07:46:33 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 7 May 2020 07:46:30 -0400 From: Jeff King To: Junio C Hamano Cc: Solomon Ucko , git@vger.kernel.org Subject: Re: rebase -i: quick/inline reword Message-ID: <20200507114630.GC3027470@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, May 06, 2020 at 09:52:19PM -0700, Junio C Hamano wrote: > Solomon Ucko writes: > > > ... It would be much easier > > if there were a mode where any changes to the commit titles in the list > > modified the commits' titles. Maybe `git rebase -i --reword`? > > > > Any thoughts, suggestions, questions, etc.? > > It is probably a bad idea, as it encourages a single-liner commit > message without any body. There is another legitimate use (or at least one I have wished for many times): when manipulating the todo list in my editor to choose patches for editing, I sometimes notice a typo in the title and correct it. And of course that does no good, and I get annoyed. You'd think I would have learned after all these years, but I continue to make the same mistake. ;) I've often wished that changes there would be quietly persisted. Your "retitle" suggestion would help, but I'd have to remember to use it (I could equally well just remember to use "reword", which I clearly don't). So I've thought about suggesting this myself in the past, but I held back for the reasons you mentioned below (i.e., that it's not a trustworthy version of the subject in the first place). I'm not sure if it's solvable or worth solving, but I thought I'd add my 2 cents that the _desire_ at least isn't totally without merit. -Peff