From: Jeff King <peff@peff.net>
To: clime <clime7@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: git for-each-ref - sorting by multiple keys
Date: Sun, 3 May 2020 05:09:52 -0400 [thread overview]
Message-ID: <20200503090952.GA170768@coredump.intra.peff.net> (raw)
In-Reply-To: <CAGqZTUvuJgZH-YUxDTYunng3QD4-wwPgquZX1P=1P1R=Ku0s2g@mail.gmail.com>
On Sat, May 02, 2020 at 10:31:50PM +0200, clime wrote:
> I have the following command:
>
> /usr/bin/git for-each-ref --merged="${GIT_HEAD-HEAD}"
> --sort='-taggerdate' --sort='-*committerdate'
> --format="%(*committerdate)|%(taggerdate)|%(tag)" refs/tags
>
> I thought this will use: -*commiterdate as a primary key and
> -taggerdate as a secondary. According to man page for --sort: "You may
> use the --sort=<key> option multiple times, in which case the last key
> becomes the primary key."
>
> But that doesn't seem to be the case. I created a repo with a single
> commit and created annotated tags on the commit in the following
> order:
It looks like this has been quite broken since 2015 and nobody noticed. :(
Thanks for your reproduction recipe; using times is a critical part of
the bug. Here's a fix, plus a fix for a related bug I noticed while
working on it (the second one fixes your bug).
[1/2]: ref-filter: apply --ignore-case to all sorting keys
[2/2]: ref-filter: apply fallback refname sort only after all user sorts
builtin/branch.c | 2 +-
builtin/for-each-ref.c | 2 +-
builtin/tag.c | 2 +-
ref-filter.c | 13 +++++-
ref-filter.h | 2 +
t/t6300-for-each-ref.sh | 94 ++++++++++++++++++++++++++++++++++++++---
6 files changed, 104 insertions(+), 11 deletions(-)
-Peff
next prev parent reply other threads:[~2020-05-03 9:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 20:31 git for-each-ref - sorting by multiple keys clime
2020-05-03 9:09 ` Jeff King [this message]
2020-05-03 9:11 ` [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys Jeff King
2020-05-03 11:44 ` Danh Doan
2020-05-04 15:13 ` Jeff King
2020-05-04 15:37 ` Junio C Hamano
2020-05-04 16:07 ` [PATCH] CodingGuidelines: drop arithmetic expansion advice to use "$x" Jeff King
2020-05-04 16:28 ` Carlo Marcelo Arenas Belón
2020-05-04 16:33 ` Jeff King
2020-05-04 19:47 ` Junio C Hamano
2020-05-04 23:32 ` Danh Doan
2020-05-05 20:40 ` Junio C Hamano
2020-05-05 21:07 ` Jeff King
2020-05-05 21:30 ` Junio C Hamano
2020-05-04 21:00 ` [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys Junio C Hamano
2020-05-05 0:11 ` Jeff King
2020-05-05 0:13 ` Taylor Blau
2020-05-03 9:13 ` [PATCH 2/2] ref-filter: apply fallback refname sort only after all user sorts Jeff King
2020-05-04 21:05 ` Junio C Hamano
2020-05-05 0:14 ` Taylor Blau
2020-05-03 10:16 ` git for-each-ref - sorting by multiple keys clime
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503090952.GA170768@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=clime7@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).