From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"Leonardo Bras" <leobras.c@gmail.com>,
git@vger.kernel.org, "Jan Viktorin" <viktorin@rehivetech.com>,
"Michal Nazarewicz" <mina86@mina86.com>
Subject: Re: [PATCH] send-email: Defines smtpPassCmd config option
Date: Fri, 1 May 2020 16:27:23 -0600 [thread overview]
Message-ID: <20200501222723.GF41612@syl.local> (raw)
In-Reply-To: <xmqqees3odrb.fsf@gitster.c.googlers.com>
On Fri, May 01, 2020 at 08:50:48AM -0700, Junio C Hamano wrote:
> Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
>
> >> +of `sendemail.smtpPassCmd`), then a password is obtained using
> >> +'git-credential'.
> >
> > this last part on git credential is just undocumented, since it is already
> > doing so since 4d31a44a08 (git-send-email: use git credential to obtain
> > password, 2013-02-12)
> >
> > and of course, assuming you use a credential helper that keeps the password
> > encrypted you could use that instead of this new feature.
>
> Up to this point I understand your response.
>
> Documenting that "git send-email" can use "git credential" for its
> password store, if it is not already documented, is of course a good
> change.
I agree completely.
> But I am not sure why this is "a good alternative". Having more
> choices that do not offer anything substantially different is a bad
> thing. Is this "new mechanism" better in what way? Simpler to use?
> Faster? Less error prone? Something else?
Ditto. I don't think that an increased surface-area of possibilities to
specify your password to 'git send-email' is useful. Put another way:
why *not* use the in-built credential helper, which is already
supported?
Would having it documented eliminate some rationale for invoking a
separate program?
> Thanks.
>
> > having said that, this looks like a good alternative, but might need to
> > make sure if die makes sense below or would be better to see if you can
> > still get a password through git credential even if that fails.
> >
> > maybe the rule of what to do might even need some configuration itself.
> >
> > Carlo
Thanks,
Taylor
next prev parent reply other threads:[~2020-05-01 22:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 10:51 [PATCH] send-email: Defines smtpPassCmd config option Leonardo Bras
2020-05-01 12:53 ` Carlo Marcelo Arenas Belón
2020-05-01 15:50 ` Junio C Hamano
2020-05-01 22:27 ` Taylor Blau [this message]
2020-05-01 23:59 ` brian m. carlson
2020-05-03 9:43 ` Jeff King
2020-05-03 16:27 ` brian m. carlson
2020-05-03 23:48 ` Carlo Marcelo Arenas Belón
2020-05-04 19:49 ` Leonardo Bras
2020-05-04 20:35 ` Jeff King
2020-05-04 21:29 ` Leonardo Bras
2020-05-04 19:09 ` Leonardo Bras
2020-05-04 19:02 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501222723.GF41612@syl.local \
--to=me@ttaylorr.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=leobras.c@gmail.com \
--cc=mina86@mina86.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).