From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 26A221F9E0 for ; Tue, 28 Apr 2020 18:01:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728506AbgD1SA7 (ORCPT ); Tue, 28 Apr 2020 14:00:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:44930 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728023AbgD1SA7 (ORCPT ); Tue, 28 Apr 2020 14:00:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B7647AE30; Tue, 28 Apr 2020 18:00:57 +0000 (UTC) Date: Tue, 28 Apr 2020 20:00:56 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Junio C Hamano Cc: Jonathan Nieder , Jonathan Tan , git@vger.kernel.org Subject: Re: [PATCH v2 1/3] fetch-pack: return enum from process_acks() Message-ID: <20200428200056.6fb5dd6b@naga.burning-in.hell> In-Reply-To: References: <20200428005333.GE36078@google.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, 28 Apr 2020 09:54:19 -0700 Junio C Hamano wrote: > Jonathan Nieder writes: > > >> /* return 0 if no common, 1 if there are common, or 2 if ready */ > > > > This comment can be removed now, which is a nice bonus. It is still present in the pu branch. Is there other branch where I should look? Thanks Michal