From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 00E041F5AD for ; Wed, 15 Apr 2020 15:16:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1414606AbgDOPQz (ORCPT ); Wed, 15 Apr 2020 11:16:55 -0400 Received: from cloud.peff.net ([104.130.231.41]:54550 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S2393356AbgDOPQy (ORCPT ); Wed, 15 Apr 2020 11:16:54 -0400 Received: (qmail 12504 invoked by uid 109); 15 Apr 2020 15:16:52 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Wed, 15 Apr 2020 15:16:52 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 4268 invoked by uid 111); 15 Apr 2020 15:27:39 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 15 Apr 2020 11:27:39 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 15 Apr 2020 11:16:52 -0400 From: Jeff King To: Junio C Hamano Cc: Jonathan Nieder , Jonathan Tan , git@vger.kernel.org Subject: Re: Fetching 24 Linux commits = 1.2 GiB Message-ID: <20200415151652.GB2464307@coredump.intra.peff.net> References: <20200415135627.vx75hsphbpmgrquv@chatter.i7.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Apr 15, 2020 at 08:08:17AM -0700, Junio C Hamano wrote: > Do these (and I think we saw other reports) make us rethink the > status of protocol v2 as the default? Are all of these fallouts > we saw so far easy-to-fix bugs, or are there more fundamental issues > in the v2 protocol design? I don't think we know yet. I agree with Konstantin that the v2 switch is the likely culprit for these issues, but without having been able to reproduce, I don't think we know exactly what the problem is yet. It could be a protocol design issue, or it could be a minor implementation bug. Note that there is one other issue that's turned up, that I discussed here: https://lore.kernel.org/git/20200328154936.GA1217052@coredump.intra.peff.net/ That's more fundamental to the v2 design, but: - it only happens when one side drops the connection, so it's not impacting normal operation (it does turn an error case into a hang, though, which can be rather annoying) - it's not in the network protocol itself, but rather the protocol between Git and the remote helper. So we could solve it purely as a client-side fix. -Peff