From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id AE0401F5AD for ; Tue, 14 Apr 2020 20:17:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2632965AbgDNURs (ORCPT ); Tue, 14 Apr 2020 16:17:48 -0400 Received: from cloud.peff.net ([104.130.231.41]:53684 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S2632807AbgDNURg (ORCPT ); Tue, 14 Apr 2020 16:17:36 -0400 Received: (qmail 7495 invoked by uid 109); 14 Apr 2020 20:17:34 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 14 Apr 2020 20:17:34 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1455 invoked by uid 111); 14 Apr 2020 20:28:19 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 14 Apr 2020 16:28:19 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 14 Apr 2020 16:17:33 -0400 From: Jeff King To: =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh Cc: git@vger.kernel.org, "Brian M . Carlson" Subject: Re: [PATCH 1/2] date.c: allow fractional second part of ISO-8601 Message-ID: <20200414201733.GB1879688@coredump.intra.peff.net> References: <20200414000324.GA2751707@camp.crustytoothpaste.net> <45676f4a7d001dbd25bbae531cc2ae5fc53936bb.1586856398.git.congdanhqx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <45676f4a7d001dbd25bbae531cc2ae5fc53936bb.1586856398.git.congdanhqx@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Apr 14, 2020 at 04:31:54PM +0700, Đoàn Trần Công Danh wrote: > diff --git a/date.c b/date.c > index b0d9a8421d..2f37397beb 100644 > --- a/date.c > +++ b/date.c > @@ -556,6 +556,8 @@ static int match_multi_number(timestamp_t num, char c, const char *date, > case ':': > if (num3 < 0) > num3 = 0; > + else if (*end == '.' && isdigit(end[1])) > + strtol(end + 1, &end, 10); This just throws away the fractional part. I doubt anybody cares much either way, but another option would be to round num3 up or down. -Peff