git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Lukas Pupka-Lipinski <lukas.pupkalipinski@lpl-mind.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] added: Multi line support for ignore-paths configuration
Date: Mon, 13 Apr 2020 18:18:05 +0000	[thread overview]
Message-ID: <20200413181805.GA1872@dcvr> (raw)
In-Reply-To: <8fbfbf1c-ea14-6739-7881-cfa3d9642de9@lpl-mind.de>

Lukas Pupka-Lipinski <lukas.pupkalipinski@lpl-mind.de> wrote:

Sorry for the long delay, had other stuff to deal with.
(and off-list replies with HTML doesn't take high priority)

> Am 30.03.2020 um 01:24 schrieb Eric Wong:
> > > Am 25.03.2020 um 21:38 schrieb Eric Wong:
> > > > > 2.25.1.windows.1
> > > > I'm not sure how git-config or chomp() behaves on Windows systems
> > > > with CRLF line endings, though.
> > > > 
> > > > A possibility would be replacing chomp(@v) with:
> > > > 
> > > > 	s/\r?\n\z//s for @v;
> > > Yes that has to be done. Its implemented in
> > > 
> > > +    $v  =~ s/[\x0A\x0D]//g if (defined $v);
> > Does that mean you'll send a v2 of the patch which uses
> > 
> > 	s/\r?\n\z//s for @v;
> > 
> > ?
> 
> Its already in the patch. Line
> 
> +    $v  =~ s/[\x0A\x0D]//g if (defined $v);

Please reread my original message about how `$v'
as a scalar is incorrect (and thus your s///g):

https://lore.kernel.org/git/20200325203823.GA21913@dcvr/

The correct operations are on `@v' as an array,
`$v' as a scalar.  Thanks.

      parent reply	other threads:[~2020-04-13 18:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25  6:56 [PATCH] added: Multi line support for ignore-paths configuration Lukas Pupka-Lipinski
2020-03-25 20:38 ` Eric Wong
2020-03-25 21:24   ` Junio C Hamano
     [not found]   ` <0515a11b-d9ae-3f22-65a8-5efee235d5c9@lpl-mind.de>
2020-03-29 23:24     ` Eric Wong
     [not found]       ` <8fbfbf1c-ea14-6739-7881-cfa3d9642de9@lpl-mind.de>
2020-04-13 18:18         ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200413181805.GA1872@dcvr \
    --to=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=lukas.pupkalipinski@lpl-mind.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).