From: Taylor Blau <email@example.com> To: Jeff King <firstname.lastname@example.org> Cc: Taylor Blau <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH 0/6] better handling of gigantic config files Date: Mon, 13 Apr 2020 11:23:40 -0600 [thread overview] Message-ID: <20200413172340.GB63249@syl.local> (raw) In-Reply-To: <20200413172052.GB8183@coredump.intra.peff.net> On Mon, Apr 13, 2020 at 01:20:52PM -0400, Jeff King wrote: > On Sun, Apr 12, 2020 at 06:49:27PM -0600, Taylor Blau wrote: > > > Thanks for doing this. I knew that it rang a bell for some reason, but > > it was because of the upload-pack changes to limit the set of allowed > > object filter choices that I'd sent as an RFC somewhere. > > > > I was using 'parse_config_key()', and I think that you noted somewhere > > that it was odd that it filled an int and not a size_t. So, thanks very > > much for fixing that case. > > Yes, your patch was part of why it was on my mind, though really all of > this is the culmination of many years of annoyance. :) > > You'll have to update your code to use size_t when the two are merged > together. I don't think there's anything else in flight that needs > similar treatment, though. Nope, just that. Easy enough :). > -Peff Thanks, Taylor
prev parent reply other threads:[~2020-04-13 17:23 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-10 19:42 Jeff King 2020-04-10 19:43 ` [PATCH 1/6] remote: drop auto-strlen behavior of make_branch() and make_rewrite() Jeff King 2020-04-10 21:44 ` Junio C Hamano 2020-04-10 19:44 ` [PATCH 2/6] parse_config_key(): return subsection len as size_t Jeff King 2020-04-10 19:44 ` [PATCH 3/6] config: drop useless length variable in write_pair() Jeff King 2020-04-10 21:51 ` Junio C Hamano 2020-04-10 19:46 ` [PATCH 4/6] git_config_parse_key(): return baselen as size_t Jeff King 2020-04-10 19:47 ` [PATCH 5/6] config: use size_t to store parsed variable baselen Jeff King 2020-04-10 19:50 ` [PATCH 6/6] config: reject parsing of files over INT_MAX Jeff King 2020-04-10 22:04 ` Junio C Hamano 2020-04-10 22:15 ` Jeff King 2020-04-13 0:47 ` Taylor Blau 2020-04-13 22:14 ` Junio C Hamano 2020-04-13 0:49 ` [PATCH 0/6] better handling of gigantic config files Taylor Blau 2020-04-13 17:20 ` Jeff King 2020-04-13 17:23 ` Taylor Blau [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200413172340.GB63249@syl.local \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/6] better handling of gigantic config files' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).