From: Danh Doan <congdanhqx@gmail.com>
To: Allo via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Allo <dinoallosaurus1111@gmail.com>
Subject: Re: [PATCH v2] t4200-rerere.sh: use test_path_is_* functions in the script
Date: Thu, 9 Apr 2020 22:21:34 +0700 [thread overview]
Message-ID: <20200409152134.GC1937@danh.dev> (raw)
In-Reply-To: <pull.595.v2.git.1586444061576.gitgitgadget@gmail.com>
On 2020-04-09 14:54:21+0000, Allo via GitGitGadget <gitgitgadget@gmail.com> wrote:
> From: Angel Pan <dinoallosaurus1111@gmail.com>
>
> Subject: t4200-rerere.sh: use test_path_is_* functions in the script
"in the script" looks too verbose to me. Because the script has been
mentioned earlier.
> The original code works fine. However, since the code base has already had help-functions(in test-lib-functions),
We wrap lines at 72 characters per line.
And, missing space before open parenthese.
I'm not good at wording, but I think this commit message is too
verbose. I would say something like:
Prefer "test_path_is_dir" to "test -d" and test_path_is_file
to "test -f" because they're more friendly to debug.
That's not a good message, either. But, it's some what simpler and
cleaner.
> the change is able to help people understand the code better, as well as improve debug-friendliness.
>
> * t4200-rerere.sh: replace "test -d" with "test_path_is_dir"
> * t4200-rerere.sh: replace "test -f" with "test_path_is_file"
>
--
Danh
next prev parent reply other threads:[~2020-04-09 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 17:16 [PATCH] t4200-rerere.sh: use test_path_is_* functions in the script Allo via GitGitGadget
2020-04-09 14:54 ` [PATCH v2] " Allo via GitGitGadget
2020-04-09 15:21 ` Danh Doan [this message]
2020-04-09 18:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409152134.GC1937@danh.dev \
--to=congdanhqx@gmail.com \
--cc=dinoallosaurus1111@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).