mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Danh Doan <>
To: Allo via GitGitGadget <>
Cc:, Allo <>
Subject: Re: [PATCH v2] use test_path_is_* functions in the script
Date: Thu, 9 Apr 2020 22:21:34 +0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 2020-04-09 14:54:21+0000, Allo via GitGitGadget <> wrote:
> From: Angel Pan <>
> Subject: use test_path_is_* functions in the script

"in the script" looks too verbose to me. Because the script has been
mentioned earlier.

> The original code works fine. However, since the code base has already had help-functions(in test-lib-functions),

We wrap lines at 72 characters per line.
And, missing space before open parenthese.

I'm not good at wording, but I think this commit message is too
verbose. I would say something like:

	Prefer "test_path_is_dir" to "test -d" and test_path_is_file
	to "test -f" because they're more friendly to debug.

That's not a good message, either. But, it's some what simpler and

> the change is able to help people understand the code better, as well as improve debug-friendliness.
> * replace "test -d" with "test_path_is_dir"
> * replace "test -f" with "test_path_is_file"


  reply	other threads:[~2020-04-09 15:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 17:16 [PATCH] use test_path_is_* functions in the script Allo via GitGitGadget
2020-04-09 14:54 ` [PATCH v2] " Allo via GitGitGadget
2020-04-09 15:21   ` Danh Doan [this message]
2020-04-09 18:09     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).