From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 4E3641F5AD for ; Thu, 9 Apr 2020 14:16:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727220AbgDIOP7 (ORCPT ); Thu, 9 Apr 2020 10:15:59 -0400 Received: from cloud.peff.net ([104.130.231.41]:38042 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727079AbgDIOP7 (ORCPT ); Thu, 9 Apr 2020 10:15:59 -0400 Received: (qmail 19206 invoked by uid 109); 9 Apr 2020 14:15:59 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 09 Apr 2020 14:15:59 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 18503 invoked by uid 111); 9 Apr 2020 14:26:29 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 09 Apr 2020 10:26:29 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 9 Apr 2020 10:15:59 -0400 From: Jeff King To: Derrick Stolee Cc: Derrick Stolee via GitGitGadget , git@vger.kernel.org, Derrick Stolee , Philip Oakley Subject: Re: [PATCH] bloom: ignore renames when computing changed paths Message-ID: <20200409141559.GD3494212@coredump.intra.peff.net> References: <20200408223111.GC3468797@coredump.intra.peff.net> <72fa2e30-b841-9600-ae2c-21a269817f1c@gmail.com> <20200409134724.GA3494212@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Apr 09, 2020 at 10:00:46AM -0400, Derrick Stolee wrote: > >> So our issue was really that the partial clone prefetch logic was just > >> overly aggressive. > > > > Right, but I'm not sure how this patch could ever have helped, since > > it's just setting a variable to the value it _should_ have already had. > > > > Or do you just mean that the issue would have gone away with Jonathan's > > patch to make the prefetching less aggressive? > > Yes, with Jonathan's patch we stop downloading blobs during Bloom filter > computations. The patch this is "replacing" disabled that download in a > different way, depending only on if detect_renames is false and the diff > output doesn't need file contents. (Jonathan's is better.) OK. I'm willing to leave it there, but I'm still puzzled as to why the original patch would have done anything based on detect_renames, which would always be false. -Peff