From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 9B6641F487 for ; Fri, 3 Apr 2020 23:10:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727924AbgDCXKX (ORCPT ); Fri, 3 Apr 2020 19:10:23 -0400 Received: from cloud.peff.net ([104.130.231.41]:33144 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727829AbgDCXKX (ORCPT ); Fri, 3 Apr 2020 19:10:23 -0400 Received: (qmail 31747 invoked by uid 109); 3 Apr 2020 23:10:23 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 03 Apr 2020 23:10:23 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 24445 invoked by uid 111); 3 Apr 2020 23:20:36 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 03 Apr 2020 19:20:36 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 3 Apr 2020 19:10:21 -0400 From: Jeff King To: SZEDER =?utf-8?B?R8OhYm9y?= Cc: Taylor Blau , Junio C Hamano , Derrick Stolee , git@vger.kernel.org Subject: Re: [PATCH 3/3] commit-graph: error out on invalid commit oids in 'write --stdin-commits' Message-ID: <20200403231021.GA672258@coredump.intra.peff.net> References: <20190805080240.30892-1-szeder.dev@gmail.com> <20190805080240.30892-4-szeder.dev@gmail.com> <20200403183057.GA659224@coredump.intra.peff.net> <20200403184933.GA57202@syl.local> <20200403193842.GA7859@szeder.dev> <20200403195103.GA663412@coredump.intra.peff.net> <20200403204013.GC7859@szeder.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200403204013.GC7859@szeder.dev> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Apr 03, 2020 at 10:40:13PM +0200, SZEDER Gábor wrote: > > Do you care about complaining about: > > > > git rev-parse HEAD^{tree} | git commit-graph write --stdin-commits > > > > ? That's the case that's much more interesting, I think. > > Hm, are you trying to go in the direction where '--stdin-commits' > would keep erroring out on any non-full-hex-oid, but would accept and > silently ignore any hex oids that are not commits (perhaps even when > there is no such object, dunno)? I think that would support the use > cases you mentioned, while it would still save me when I do the 'echo > ' thing (somehow I regularly do that, remember doing it the day > before yesterday!). Yes, exactly. The case you care about and the case I care about are different ones, so there's no inherent conflict between them. -Peff