From: Eric Wong <email@example.com> To: Lukas Pupka-Lipinski <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [PATCH] added: Multi line support for ignore-paths configuration Date: Sun, 29 Mar 2020 23:24:04 +0000 [thread overview] Message-ID: <20200329232404.GA12701@dcvr> (raw) In-Reply-To: <firstname.lastname@example.org> Lukas Pupka-Lipinski <email@example.com> wrote: > Hi Eric, > > thanks for your feedback. > > I will include your general Feedback in the next Patch mail. > > In Addition i think its not clear what i was trying to solve. I use the git > svn extension for our company SVN. Unfortunately we have a lot of stuff in > the SVN what I do not use and don’t want to checkout. So I started to use > the ignore-paths option. But git only allows to have ca. 150 char in one > config line. Which is not enough for me. So I started to extend the code to > use also the next line. So that your expression can be bigger than 150 char, > spread over several lines. Thanks for the explanation. In the future, please keep firstname.lastname@example.org and anybody else in the discussion in the Cc: list (use reply-to-all in your mailer). > I hope that make it clear. OK, please do, thank you :) > I will resend the second mail in few seconds > > > That looks like it would munge the following: > > > > [svn-remote "foo"] > > ignore-paths = a > > ignore-paths = b > > > > into "a\nb\n" > > > > And finally into a regexp:/ab/ > > > > ...Which doesn't seem correct, to me. > > No this will end up into "ab" the \n and \r are removed at > > + $v =~ s/[\x0A\x0D]//g if (defined $v); Right, so do you agree your patch is broken in that case and needs fixing? Sorry, my mental abilities are dulled from the stress and insomnia caused by the pandemic, so I have more trouble understanding things than usual :< > Am 25.03.2020 um 21:38 schrieb Eric Wong: > > > 2.25.1.windows.1 > > I'm not sure how git-config or chomp() behaves on Windows systems > > with CRLF line endings, though. > > > > A possibility would be replacing chomp(@v) with: > > > > s/\r?\n\z//s for @v; > > Yes that has to be done. Its implemented in > > + $v =~ s/[\x0A\x0D]//g if (defined $v); Does that mean you'll send a v2 of the patch which uses s/\r?\n\z//s for @v; ? Thanks in advance for clarifying.
next prev parent reply other threads:[~2020-03-29 23:24 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-25 6:56 Lukas Pupka-Lipinski 2020-03-25 20:38 ` Eric Wong 2020-03-25 21:24 ` Junio C Hamano [not found] ` <email@example.com> 2020-03-29 23:24 ` Eric Wong [this message] [not found] ` <firstname.lastname@example.org> 2020-04-13 18:18 ` Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200329232404.GA12701@dcvr \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] added: Multi line support for ignore-paths configuration' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).