From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id BFE7F1F487 for ; Fri, 27 Mar 2020 09:37:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727606AbgC0JhM (ORCPT ); Fri, 27 Mar 2020 05:37:12 -0400 Received: from cloud.peff.net ([104.130.231.41]:53358 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1725956AbgC0JhM (ORCPT ); Fri, 27 Mar 2020 05:37:12 -0400 Received: (qmail 10148 invoked by uid 109); 27 Mar 2020 09:37:11 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 27 Mar 2020 09:37:11 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23484 invoked by uid 111); 27 Mar 2020 09:47:08 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 27 Mar 2020 05:47:08 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 27 Mar 2020 05:37:10 -0400 From: Jeff King To: Taylor Blau Cc: Jonathan Tan , git@vger.kernel.org Subject: Re: [RFC PATCH] fetch-pack: lazy fetch using tree:0 Message-ID: <20200327093710.GA611304@coredump.intra.peff.net> References: <20200319174439.230969-1-jonathantanmy@google.com> <20200320061214.GA511478@coredump.intra.peff.net> <20200326195058.GA8613@syl.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200326195058.GA8613@syl.local> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Mar 26, 2020 at 01:50:58PM -0600, Taylor Blau wrote: > > One side note (for Taylor, cc'd): our patches elsewhere to limit the > > allowed filters don't make it possible to express the difference between > > "tree:0" and "tree:1". It may be worth thinking about that, especially > > if it influences the config schema (since we'll have to support it > > forever once it makes it into a release). > [...] > [uploadpack "filter.tree:depth"] > allow = true > maxDepth = Yeah, that scheme solves the problem very neatly, and removes any worry I had about painting ourselves into a corner. Thanks. -Peff