From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 20F421F487 for ; Fri, 27 Mar 2020 09:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726439AbgC0JNi (ORCPT ); Fri, 27 Mar 2020 05:13:38 -0400 Received: from cloud.peff.net ([104.130.231.41]:53346 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726165AbgC0JNi (ORCPT ); Fri, 27 Mar 2020 05:13:38 -0400 Received: (qmail 10073 invoked by uid 109); 27 Mar 2020 09:13:37 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 27 Mar 2020 09:13:37 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23374 invoked by uid 111); 27 Mar 2020 09:23:33 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 27 Mar 2020 05:23:33 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 27 Mar 2020 05:13:36 -0400 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com, martin.agren@gmail.com, szeder.dev@gmail.com Subject: Re: [PATCH v4] builtin/commit-graph.c: support '--input=graphed' Message-ID: <20200327091336.GC610157@coredump.intra.peff.net> References: <7c47f37122ff2b03f0bccc48cb6ca022904f6353.1583278022.git.me@ttaylorr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Mar 23, 2020 at 02:12:19PM -0600, Taylor Blau wrote: > Hi, > > In response to some discussion in [1], here is another idea instead of > '--input=none' that may make things a little clearer. Since it had been > a long time, I reminded myself that '--input=none' means > "--input=append, but don't look at packs as is usually the default". > > In [1], Gabor suggested that we could call this '--input=exists' or > '--input=existing', but I think that 'graphed' may be clearer, since > it is closer to "only _graphed_ commits". Yeah, this name is much more clear to me than "none" (and would have prevented some mild confusion I had when experimenting the other day). > Another option would be to call this '--input=only-graphed', but I think > that may be overly verbose for what we're going for here. Agreed. -Peff