From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id BFF671F487 for ; Thu, 26 Mar 2020 08:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbgCZIu5 (ORCPT ); Thu, 26 Mar 2020 04:50:57 -0400 Received: from cloud.peff.net ([104.130.231.41]:51978 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726210AbgCZIu5 (ORCPT ); Thu, 26 Mar 2020 04:50:57 -0400 Received: (qmail 1702 invoked by uid 109); 26 Mar 2020 08:50:57 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 26 Mar 2020 08:50:57 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12486 invoked by uid 111); 26 Mar 2020 09:00:51 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 26 Mar 2020 05:00:51 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 26 Mar 2020 04:50:56 -0400 From: Jeff King To: Johannes Schindelin via GitGitGadget Cc: git@vger.kernel.org, Junio C Hamano , Johannes Schindelin Subject: Re: [PATCH v2 5/5] tests: increase the verbosity of the GPG-related prereqs Message-ID: <20200326085056.GF2200716@coredump.intra.peff.net> References: <5e89b512513af0e2e16dc93c86ae3d1145061a82.1585114881.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5e89b512513af0e2e16dc93c86ae3d1145061a82.1585114881.git.gitgitgadget@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Mar 25, 2020 at 05:41:21AM +0000, Johannes Schindelin via GitGitGadget wrote: > Let's fix this by no longer redirecting the output not to `/dev/null`. > This is now possible because the affected prereqs were turned into lazy > ones (and are therefore evaluated via `test_eval_` which respects the > `--verbose` option). > > Note that we _still_ redirect `stdout` to `/dev/null` for those commands > that sign their `stdin`, as the output would be binary (and useless > anyway, because the reader would not have anything against which to > compare the output). This looks good. You could drop the redirection of stdin in one case, too (since test_eval_ already does so) but I don't mind leaving it as documentation. -Peff