From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id A63001F487 for ; Thu, 26 Mar 2020 08:33:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbgCZIdu (ORCPT ); Thu, 26 Mar 2020 04:33:50 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:46419 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727724AbgCZIdt (ORCPT ); Thu, 26 Mar 2020 04:33:49 -0400 Received: by mail-qt1-f195.google.com with SMTP id g7so4525592qtj.13 for ; Thu, 26 Mar 2020 01:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D96jcjhVpaC9m72qQAKK+4RL5O8n4rSe+77qJyfq+XQ=; b=aya4E3b1x2MivEKSKUe1kacpO+mIZ1PkAnANT9C26FWzalnFbso5kVIrKkEFaxUv+m i9ZHZHVuAJF2a/EbV3GNc+Q58jF5OsNfwDhgSTORHK2dkvJqkK+fYPMMQ6FISzZ8Qmfy SReVxKXcIwzcbwPNL/Qeeh7t6KuuqvPZ2L/aDWK54efPOuYXKRF/lfdWjKivAsk2PFid nxt/ETklLgLGdKuqTljcOt8rYCXUOwVbXhthAZY0p7oq0Cq00k/zZXyYrV+mpmcY74y9 DaqtmZBjNJ622W59pavJIVC/lOJ7Is9H8Cwxe5i/9lSBpGsH1jFEkO1eiN7j4XUGAaxX UA1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D96jcjhVpaC9m72qQAKK+4RL5O8n4rSe+77qJyfq+XQ=; b=oktzHiMT4hqHZCcn9ptkWbkAAu1Fu6o2Jyv/UT1iJDSKLzoLsuZ55N9roI76A2SHKC kgHpR6r0mAd8r3v+7slxjqtb+iCKSqSDqiCekfzcdKIjc5GBiHqQ1F7OR8CS4PuDMot0 j6qMwxHZRmlSJiFT/3yyIeV3RgWA2DwPMH0fZoR1s8chl5RKebYJJEllOyyjXxDzaisY sxO6K4FqAYjGYT04+GkfZSRM4sKnXBNeCEsw8up6FjkM4oB836uu8RsFcK49lu+PDPVV AXyotawy0dSjlIbDGMaRpYJtlHGRsr7RG935BKgGDxwJoNNA3hyxbQcTorEbAGp2Yjhj u6uQ== X-Gm-Message-State: ANhLgQ058c2TUVDPr2EPGQMH4XALQrnvj1C8d1mpIvaBiu5/Si7u3Xdh 1e3bM137Q9wKet9hKqs3VLKnw9ky X-Google-Smtp-Source: ADFU+vtvZ+dlydO0/EYnjdiR/6iup4z5QoVf7N6hbBtJWb3I0AECRVLUskbsW8EdriFGJRfEprZa1g== X-Received: by 2002:ac8:499a:: with SMTP id f26mr6852770qtq.71.1585211628402; Thu, 26 Mar 2020 01:33:48 -0700 (PDT) Received: from generichostname ([199.249.110.29]) by smtp.gmail.com with ESMTPSA id c14sm1134028qtv.32.2020.03.26.01.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2020 01:33:47 -0700 (PDT) Date: Thu, 26 Mar 2020 04:33:46 -0400 From: Denton Liu To: Jeff King Cc: git@vger.kernel.org, Johannes Schindelin , Junio C Hamano Subject: Re: [PATCH 1/2] t/lib-credential.sh: drop shebang line Message-ID: <20200326083346.GA1891350@generichostname> References: <20200326082338.GA3611364@coredump.intra.peff.net> <20200326082527.GA3611762@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200326082527.GA3611762@coredump.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Mar 26, 2020 at 04:25:27AM -0400, Jeff King wrote: > The purpose of lib-credential.sh is to be sourced into other test > scripts. It doesn't need a "#!/bin/sh" line, as running it directly > makes no sense. Nor does it serve any real filetype documentation > purpose, as the file is cleary named with a ".sh" extension. s/cleary/clearly/ Patch and message look obviously good otherwise.