From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 851FB1F487 for ; Thu, 26 Mar 2020 08:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbgCZIVm (ORCPT ); Thu, 26 Mar 2020 04:21:42 -0400 Received: from cloud.peff.net ([104.130.231.41]:51860 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727717AbgCZIVm (ORCPT ); Thu, 26 Mar 2020 04:21:42 -0400 Received: (qmail 1236 invoked by uid 109); 26 Mar 2020 08:21:41 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 26 Mar 2020 08:21:41 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12116 invoked by uid 111); 26 Mar 2020 08:31:35 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 26 Mar 2020 04:31:35 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 26 Mar 2020 04:21:40 -0400 From: Jeff King To: Johannes Schindelin via GitGitGadget Cc: git@vger.kernel.org, Junio C Hamano , Johannes Schindelin Subject: Re: [PATCH v2 2/5] t/lib-gpg.sh: stop pretending to be a stand-alone script Message-ID: <20200326082140.GC2200716@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Mar 25, 2020 at 05:41:18AM +0000, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > It makes no sense to call `./lib-gpg.sh`. Therefore the hash-bang line > is unnecessary. I wondered if it might be useful to identify the file for editors, etc. But "*.sh" is quite sufficient, and we already stripped most of these out long ago in b54a31243b (t/lib-*.sh: drop executable bit, 2020-03-26). There's some other related cleanup. I'll prepare a separate series. -Peff