From: Danh Doan <congdanhqx@gmail.com> To: Johannes Schindelin <Johannes.Schindelin@gmx.de> Cc: git@vger.kernel.org Subject: Re: [PATCH v2 6/8] t7063: drop non-POSIX argument "-ls" from find(1) Date: Mon, 23 Mar 2020 22:11:49 +0700 Message-ID: <20200323151149.GD11801@danh.dev> (raw) In-Reply-To: <nycvar.QRO.7.76.6.2003231509150.46@tvgsbejvaqbjf.bet> On 2020-03-23 15:11:50+0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: > Hi, > > On Sun, 22 Mar 2020, Đoàn Trần Công Danh wrote: > > > Since commit 6b7728db81, (t7063: work around FreeBSD's lazy mtime > > update feature, 2016-08-03), we started to use ls as a trick to update > > directory's mtime. > > > > However, `-ls` flag isn't required by POSIX's find(1), and > > busybox(1) doesn't implement it. > > > > >From the original conversation, it seems like find(1) with "-type d" > > could trigger enough "lstat(2)" to ask FreeBSD update mtime. > > This rationale makes me uneasy: why did Duy add _both_ `-type d` *and* > `-ls` if the former would have been enough? > > > Use only filter "-type d" for now. > > > > Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> > > --- > > t/t7063-status-untracked-cache.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/t/t7063-status-untracked-cache.sh b/t/t7063-status-untracked-cache.sh > > index 190ae149cf..6791c6b95a 100755 > > --- a/t/t7063-status-untracked-cache.sh > > +++ b/t/t7063-status-untracked-cache.sh > > @@ -18,7 +18,7 @@ GIT_FORCE_UNTRACKED_CACHE=true > > export GIT_FORCE_UNTRACKED_CACHE > > > > sync_mtime () { > > - find . -type d -ls >/dev/null > > + find . -type d >/dev/null > > A more conservative patch would be the following: > > -- snip -- > commit 1680a64fae24b1073dbf1b844889a9953823b7a2 > Author: Johannes Schindelin <Johannes.Schindelin@gmx.de> > Date: Wed Jul 19 22:13:16 2017 +0200 > > t7063: when running under BusyBox, avoid unsupported find option > > BusyBox' find implementation does not understand the -ls option, so > let's not use it when we're running inside BusyBox. Yes, this patch is a conservative patch. In v1, I went with "-exec ls -dils {} +". And, Jeff worries about a lot of flags passed to ls may run into compatibility issue. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > diff --git a/t/t7063-status-untracked-cache.sh > b/t/t7063-status-untracked-cache.sh > index 190ae149cf3c..ab7e8b5fea01 100755 > --- a/t/t7063-status-untracked-cache.sh > +++ b/t/t7063-status-untracked-cache.sh > @@ -18,7 +18,12 @@ GIT_FORCE_UNTRACKED_CACHE=true > export GIT_FORCE_UNTRACKED_CACHE > > sync_mtime () { > - find . -type d -ls >/dev/null > + if test_have_prereq BUSYBOX > + then > + find . -type d -print0 | xargs -0r ls -ld >/dev/null Can we just change back to what Duy proposed time ago: find . -type d -exec ls -ld {} \; > + else > + find . -type d -ls >/dev/null > + fi > } > > avoid_racy() { > -- snap -- > > I have this in Git for Windows' fork, although I have to admit that there > is no CI set up to verify that this is all working as I expect it to. I'd find some time (later) to setup a Travis build with Alpine and VoidLinux, mainly for musl check. -- Danh
next prev parent reply other threads:[~2020-03-23 15:11 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-22 0:55 [PATCH v2 0/8] fix test failure with busybox Đoàn Trần Công Danh 2020-03-22 0:55 ` [PATCH v2 1/8] t4061: use POSIX compliant regex(7) Đoàn Trần Công Danh 2020-03-22 0:55 ` [PATCH v2 2/8] test-lib-functions: test_cmp: eval $GIT_TEST_CMP Đoàn Trần Công Danh 2020-03-22 0:55 ` [PATCH v2 3/8] t5003: drop the subshell in test_lazy_prereq Đoàn Trần Công Danh 2020-03-22 0:55 ` [PATCH v2 4/8] t5003: skip conversion test if unzip -a is unavailable Đoàn Trần Công Danh 2020-03-22 0:55 ` [PATCH v2 5/8] t5616: use rev-parse instead to get HEAD's object_id Đoàn Trần Công Danh 2020-03-22 0:55 ` [PATCH v2 6/8] t7063: drop non-POSIX argument "-ls" from find(1) Đoàn Trần Công Danh 2020-03-23 14:11 ` Johannes Schindelin 2020-03-23 14:37 ` Torsten Bögershausen 2020-03-23 15:11 ` Danh Doan [this message] 2020-03-23 20:30 ` Junio C Hamano 2020-03-23 15:55 ` Junio C Hamano 2020-03-24 22:31 ` Johannes Schindelin 2020-03-24 23:46 ` Junio C Hamano 2020-03-22 0:55 ` [PATCH v2 7/8] t4124: fix test for non-compliant diff(1) Đoàn Trần Công Danh 2020-03-23 13:58 ` Johannes Schindelin 2020-03-23 15:04 ` Danh Doan 2020-03-23 20:50 ` Junio C Hamano 2020-03-24 3:40 ` Danh Doan 2020-03-24 18:47 ` Junio C Hamano 2020-03-25 14:24 ` Danh Doan 2020-03-24 22:29 ` Johannes Schindelin 2020-03-24 23:37 ` Junio C Hamano 2020-03-25 18:23 ` Johannes Schindelin 2020-03-22 0:55 ` [PATCH v2 8/8] t5703: feed raw data into test-tool unpack-sideband Đoàn Trần Công Danh 2020-03-22 6:08 ` [PATCH v2 0/8] fix test failure with busybox Jeff King 2020-03-26 4:37 ` [PATCH v4 " Đoàn Trần Công Danh 2020-03-26 4:37 ` [PATCH v4 1/8] t4061: use POSIX compliant regex(7) Đoàn Trần Công Danh 2020-03-26 4:37 ` [PATCH v4 2/8] test-lib-functions: test_cmp: eval $GIT_TEST_CMP Đoàn Trần Công Danh 2020-03-26 4:37 ` [PATCH v4 3/8] t5003: drop the subshell in test_lazy_prereq Đoàn Trần Công Danh 2020-03-26 4:37 ` [PATCH v4 4/8] t5003: skip conversion test if unzip -a is unavailable Đoàn Trần Công Danh 2020-03-26 4:37 ` [PATCH v4 5/8] t5616: use rev-parse instead to get HEAD's object_id Đoàn Trần Công Danh 2020-03-26 4:37 ` [PATCH v4 6/8] t7063: drop non-POSIX argument "-ls" from find(1) Đoàn Trần Công Danh 2020-03-26 4:37 ` [PATCH v4 7/8] t4124: fix test for non-compliant diff(1) Đoàn Trần Công Danh 2020-03-27 1:18 ` Junio C Hamano 2020-03-26 4:37 ` [PATCH v4 8/8] t5703: feed raw data into test-tool unpack-sideband Đoàn Trần Công Danh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200323151149.GD11801@danh.dev \ --to=congdanhqx@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=git@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git