git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Adrian Wijaya <adrianwijaya100@gmail.com>
To: git@vger.kernel.org
Cc: peff@peff.net, Adrian Wijaya <adrianwijaya100@gmail.com>
Subject: [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file"
Date: Fri, 20 Mar 2020 23:07:23 +0700	[thread overview]
Message-ID: <20200320160723.15190-1-adrianwijaya100@gmail.com> (raw)
In-Reply-To: <CA+0Uiy-gtdn07=QOx3JcOH-zhMz5yAKOW6=9mNc8Zi+RdfWGyQ@mail.gmail.com>

Convert "test -f" with "test_path_is_file" to give more verbose
test output on failure.

Signed-off-by: Adrian Wijaya <adrianwijaya100@gmail.com>
---
 t/t1300-config.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t1300-config.sh b/t/t1300-config.sh
index 97ebfe1f9d..d74554fc09 100755
--- a/t/t1300-config.sh
+++ b/t/t1300-config.sh
@@ -1020,11 +1020,11 @@ test_expect_success SYMLINKS 'symlinked configuration' '
 	ln -s notyet myconfig &&
 	git config --file=myconfig test.frotz nitfol &&
 	test -h myconfig &&
-	test -f notyet &&
+	test_path_is_file notyet &&
 	test "z$(git config --file=notyet test.frotz)" = znitfol &&
 	git config --file=myconfig test.xyzzy rezrov &&
 	test -h myconfig &&
-	test -f notyet &&
+	test_path_is_file notyet &&
 	cat >expect <<-\EOF &&
 	nitfol
 	rezrov
-- 
2.26.0.rc1.11.g30e9940356


  reply	other threads:[~2020-03-20 16:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 23:47 [GSOC][PATCH 1/2] t1300: replace "test -f" into "test_path_is_file" Adrian Wijaya
2020-03-19 23:47 ` [GSOC][PATCH 2/2] " Adrian Wijaya
2020-03-20  5:52   ` Jeff King
2020-03-20 15:22     ` adrian wijaya
2020-03-20 15:45 ` [GSOC][PATCH 1/2] " adrian wijaya
2020-03-20 16:07   ` Adrian Wijaya [this message]
2020-03-20 18:04     ` [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file" Junio C Hamano
2020-03-20 18:08     ` Junio C Hamano
2020-03-20 15:56 Adrian Wijaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320160723.15190-1-adrianwijaya100@gmail.com \
    --to=adrianwijaya100@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).