From: Danh Doan <congdanhqx@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/6] t4061: use POSIX compliance regex(7)
Date: Fri, 20 Mar 2020 08:35:26 +0700 [thread overview]
Message-ID: <20200320013526.GE1858@danh.dev> (raw)
In-Reply-To: <xmqqwo7gc8aq.fsf@gitster.c.googlers.com>
On 2020-03-19 15:02:37-0700, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
> > On Thu, Mar 19, 2020 at 11:53 AM Jeff King <peff@peff.net> wrote:
> >> On Thu, Mar 19, 2020 at 09:00:02PM +0700, Đoàn Trần Công Danh wrote:
> >> > Fix it by using literal `+` instead.
> >>
> >> This makes sense, I think. It could hurt a sed which is expected ERE and
> >> needs the "+" escaped, but I think such a sed would be wrong (and I
> >> imagine would break things elsewhere).
> >
> > I had the same thought and considered suggesting a character class:
> >
> > sed -n -e "1,4d" -e "s/^[+]//p" <"$1" >.tmp-1
> >
> > to make it painfully obvious that "+" is not special in the
> > expression. But then I thought better of it -- for the same reason as
> > you (to wit: such a 'sed' would be wrong) -- and decided against
> > saying anything.
>
> I have only one thing that needs fixing, which is s/compliance/compliant/;
> on the title. Other than that, it looks good.
>
> Having said that, I would have done the [+] thing if I were doing
> this patch myself. As long as we see no "wrong" sed that is broken
> by this change, I am OK with it, though.
Well, `[+]` thing was my first version for this change,
but I change in to this version afterward.
However, your comment in a later patch:
> IOW, I do not have trouble changing the test so that it works with
> noncompliant "diff". But then in the same series, I would prefer to
> see the existing test keeps working with a possibly noncompliant
> "sed" implementation that has been working well with the tests.
changed my mind.
I will use `[+]` here in the reroll.
--
Danh
next prev parent reply other threads:[~2020-03-20 1:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 14:00 [PATCH 0/6] fix test failure with busybox Đoàn Trần Công Danh
2020-03-19 14:00 ` [PATCH 1/6] t4061: use POSIX compliance regex(7) Đoàn Trần Công Danh
2020-03-19 15:53 ` Jeff King
2020-03-19 16:01 ` Eric Sunshine
2020-03-19 22:02 ` Junio C Hamano
2020-03-20 1:35 ` Danh Doan [this message]
2020-03-19 14:00 ` [PATCH 2/6] test-lib-functions: test_cmp: eval $GIT_TEST_CMP Đoàn Trần Công Danh
2020-03-19 16:02 ` Jeff King
2020-03-19 16:14 ` Eric Sunshine
2020-03-20 1:29 ` Danh Doan
2020-03-19 14:00 ` [PATCH 3/6] t5003: skip conversion test if unzip -a is unavailable Đoàn Trần Công Danh
2020-03-19 16:03 ` Jeff King
2020-03-20 0:39 ` Danh Doan
2020-03-20 5:32 ` Jeff King
2020-03-19 14:00 ` [PATCH 4/6] t5616: use rev-parse instead to get HEAD's object_id Đoàn Trần Công Danh
2020-03-19 16:07 ` Jeff King
2020-03-20 0:57 ` Danh Doan
2020-03-19 14:00 ` [PATCH 5/6] t7063: use POSIX find(1) syntax Đoàn Trần Công Danh
2020-03-19 16:12 ` Jeff King
2020-03-19 22:16 ` Junio C Hamano
2020-03-20 1:41 ` Danh Doan
2020-03-20 2:20 ` Danh Doan
2020-03-20 5:37 ` Jeff King
2020-03-22 0:37 ` Danh Doan
2020-03-22 6:05 ` Jeff King
2020-03-19 14:00 ` [PATCH 6/6] t4124: fix test for non-compliance diff Đoàn Trần Công Danh
2020-03-19 16:33 ` Jeff King
2020-03-19 22:58 ` Junio C Hamano
2020-03-20 5:20 ` Jeff King
2020-03-20 1:52 ` Danh Doan
2020-03-20 5:23 ` Jeff King
2020-03-19 15:51 ` [PATCH 0/6] fix test failure with busybox Jeff King
2020-03-20 0:37 ` Danh Doan
2020-03-20 5:30 ` Jeff King
2020-03-19 16:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320013526.GE1858@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).