From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 086371F61A for ; Thu, 19 Mar 2020 17:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727994AbgCSRKW (ORCPT ); Thu, 19 Mar 2020 13:10:22 -0400 Received: from cloud.peff.net ([104.130.231.41]:44134 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727235AbgCSRKW (ORCPT ); Thu, 19 Mar 2020 13:10:22 -0400 Received: (qmail 26318 invoked by uid 109); 19 Mar 2020 17:10:21 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 19 Mar 2020 17:10:21 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 29129 invoked by uid 111); 19 Mar 2020 17:20:00 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 19 Mar 2020 13:20:00 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 19 Mar 2020 13:10:20 -0400 From: Jeff King To: Junio C Hamano Cc: Taylor Blau , git@vger.kernel.org, christian.couder@gmail.com, james@jramsay.com.au Subject: Re: [RFC PATCH 0/2] upload-pack.c: limit allowed filter choices Message-ID: <20200319171020.GC4075823@coredump.intra.peff.net> References: <20200318101825.GB1227946@coredump.intra.peff.net> <20200318212818.GE31397@syl.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Mar 18, 2020 at 03:41:51PM -0700, Junio C Hamano wrote: > Taylor Blau writes: > > >> We tried equals, like: > >> > >> uploadpack.filter=blob:none.allow > >> > >> but there's an interesting side effect. Doing: > >> > >> git -c uploadpack.filter=blob:none.allow=true upload-pack ... > >> > >> doesn't work, because the "-c" parser ends the key at the first "=". As > >> it should, because otherwise we'd get confused by an "=" in a value. > >> This is a failing of the "-c" syntax; it can't represent values with > >> "=". > > s/value/key/ I presume ;-) Yes. :) -Peff