From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B2D881F619 for ; Thu, 19 Mar 2020 17:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727813AbgCSRJz (ORCPT ); Thu, 19 Mar 2020 13:09:55 -0400 Received: from cloud.peff.net ([104.130.231.41]:44122 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727235AbgCSRJz (ORCPT ); Thu, 19 Mar 2020 13:09:55 -0400 Received: (qmail 26298 invoked by uid 109); 19 Mar 2020 17:09:55 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 19 Mar 2020 17:09:55 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 29108 invoked by uid 111); 19 Mar 2020 17:19:34 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 19 Mar 2020 13:19:34 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 19 Mar 2020 13:09:54 -0400 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, christian.couder@gmail.com, james@jramsay.com.au Subject: Re: [RFC PATCH 0/2] upload-pack.c: limit allowed filter choices Message-ID: <20200319170954.GB4075823@coredump.intra.peff.net> References: <20200318101825.GB1227946@coredump.intra.peff.net> <20200318212818.GE31397@syl.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200318212818.GE31397@syl.local> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Mar 18, 2020 at 03:28:18PM -0600, Taylor Blau wrote: > I wonder. A multi-valued 'uploadpack.filter.allow' *might* solve some > problems, but the more I turn it over in my head, the more that I think > that it's creating more headaches for us than it's removing. IMHO we should avoid multi-valued keys when there's not a compelling reason. There are a lot of corner cases they introduce (e.g., there's no standard way to override them rather than adding to the list). > Another thing we could do is just simply use a different character. It > may be a little odd, but it keeps the filter-related variables in their > own sub-section, allowing us to add more configuration sub-variables in > the future. I guess that calling it something like: > > $ git config uploadpack.filter@blob:none.allow > > is a little strange (i.e., why '@' over '#'? There's certainly no > precedent here that I can think of...), but maybe it is slightly > less-weird than a pseudo-four-level key. I guess it's subjective, but the "@" just feels odd because it's associated with so many other meanings. Likewise "#". -Peff