git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] oidset: remove unnecessary include
Date: Mon, 16 Mar 2020 15:28:52 -0400	[thread overview]
Message-ID: <20200316192852.GC1073710@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.727.git.git.1584213347500.gitgitgadget@gmail.com>

On Sat, Mar 14, 2020 at 07:15:47PM +0000, Elijah Newren via GitGitGadget wrote:

> From: Elijah Newren <newren@gmail.com>
> 
> When commit 8b2f8cbcb1 ("oidset: use khash", 2018-10-04) moved from
> using oidmap to khash, it replaced the oidmap.h include with both one
> for hashmap.h and khash.h.  Since the hashmap.h header is unnecessary,
> and the point of the patch was to switch from hashmap (used by oidmap)
> to khash.h, remove the unneccessary include.

Good catch. I doubt this is causing problems, but it's obviously the
right thing to do. I ran "make hdr-check" to confirm that no _other_
headers were subtly relying on this include.

-Peff

      reply	other threads:[~2020-03-16 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14 19:15 [PATCH] oidset: remove unnecessary include Elijah Newren via GitGitGadget
2020-03-16 19:28 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200316192852.GC1073710@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).