From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/10] removing nth_packed_object_sha1()
Date: Tue, 25 Feb 2020 00:33:02 +0000 [thread overview]
Message-ID: <20200225003302.GK6462@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20200224042625.GA1015553@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On 2020-02-24 at 04:26:25, Jeff King wrote:
> This series gets rid of nth_packed_object_sha1(), converting its
> remaining callers to nth_packed_object_oid(). The latter provides better
> type-safety in general, and it also allowed me to clean up some tricky
> bits of the pack-verification code (patch 7 below).
>
> This was inspired by brian's work in:
>
> https://lore.kernel.org/git/20200222201749.937983-2-sandals@crustytoothpaste.net/
>
> but I decide not to base it on that series. It's semantically
> independent, and with the exception of one line, textually independent
> (patch 4 here touches a different parameter in the same call as the
> patch linked above). So I think it's easier to handle them independently
> and just resolve the trivial conflict.
I think this is the right move. The conflicts will be minor, as you
said.
The series looked good to me, and as mentioned, I appreciate you using
oidread everywhere. It's nice to get rid of more code with "sha1" in
it.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
prev parent reply other threads:[~2020-02-25 0:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 4:26 [PATCH 0/10] removing nth_packed_object_sha1() Jeff King
2020-02-24 4:27 ` [PATCH 01/10] nth_packed_object_oid(): use customary integer return Jeff King
2020-02-24 18:23 ` Jeff King
2020-02-24 4:29 ` [PATCH 02/10] pack-objects: read delta base oid into object_id struct Jeff King
2020-02-25 0:19 ` brian m. carlson
2020-02-24 4:30 ` [PATCH 03/10] pack-objects: convert oe_set_delta_ext() to use object_id Jeff King
2020-02-24 4:31 ` [PATCH 04/10] pack-objects: use object_id struct in pack-reuse code Jeff King
2020-02-24 4:32 ` [PATCH 05/10] pack-bitmap: use object_id when loading on-disk bitmaps Jeff King
2020-02-24 4:33 ` [PATCH 06/10] pack-check: convert "internal error" die to a BUG() Jeff King
2020-02-24 4:36 ` [PATCH 07/10] pack-check: push oid lookup into loop Jeff King
2020-02-24 4:36 ` [PATCH 08/10] packed_object_info(): use object_id for returning delta base Jeff King
2020-02-24 4:37 ` [PATCH 09/10] packed_object_info(): use object_id internally for " Jeff King
2020-02-24 4:37 ` [PATCH 10/10] packfile: drop nth_packed_object_sha1() Jeff King
2020-02-25 0:33 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225003302.GK6462@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).