From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] worktree: drop unused code from get_main_worktree()
Date: Mon, 24 Feb 2020 01:40:49 -0500 [thread overview]
Message-ID: <20200224064049.GD1015967@coredump.intra.peff.net> (raw)
In-Reply-To: <20200224015935.19190-1-sunshine@sunshineco.com>
On Sun, Feb 23, 2020 at 08:59:35PM -0500, Eric Sunshine wrote:
> This code has been unused since fa099d2322 (worktree.c: kill parse_ref()
> in favor of refs_resolve_ref_unsafe(), 2017-04-24), so drop it.
Looks obviously correct, unless we are depending on some side effect of
get_git_common_dir(). And if we are, then that should be fixed. ;)
-Peff
next prev parent reply other threads:[~2020-02-24 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 1:59 [PATCH] worktree: drop unused code from get_main_worktree() Eric Sunshine
2020-02-24 6:40 ` Jeff King [this message]
2020-02-24 20:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224064049.GD1015967@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).