From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matheus Tavares <matheus.bernardino@usp.br>,
git@vger.kernel.org, rhi@pengutronix.de
Subject: Re: [PATCH] describe: output tag's ref instead of embedded name
Date: Fri, 21 Feb 2020 01:00:29 -0500 [thread overview]
Message-ID: <20200221060029.GF1280313@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqsgj47l0k.fsf@gitster-ct.c.googlers.com>
On Thu, Feb 20, 2020 at 06:05:15PM -0800, Junio C Hamano wrote:
> Matheus Tavares <matheus.bernardino@usp.br> writes:
>
> >> > Another case that came to my mind is when the user runs `git describe
> >> > --abrev=0 HEAD` and v1.0-bob points to HEAD~. In this case, v1.0 will
> >> > be displayed without suffix,...
> >>
> >> In this case, v1.0-1- is followed by the full object name, I think.
> >
> > I might be doing something wrong, but this is how I tried to test this:...
>
> I only tried the commit exactly at the tag "describe --abbrev=0 v1.0-bob^0";
> you're right---the "abbrev" option strips the suffix in a separate codepath.
>
> > Then we cannot directly use the output. I think we can fix this forcing the long
> > output for this case as well, which can be done with:
>
> Thanks for a quick fix on top.
This fix makes sense. There's already a bit of ambiguity with
--no-abbrev, as it would output v1.0-1-g1234abcd as just "v1.0". But it
probably is best to draw the line here and not introduce even more
ambiguity.
-Peff
next prev parent reply other threads:[~2020-02-21 6:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 14:13 git-describe --tags warning: 'X' is really 'Y' here Roland Hieber
2020-02-05 17:15 ` Matheus Tavares Bernardino
2020-02-14 6:53 ` Jeff King
2020-02-14 16:57 ` Junio C Hamano
2020-02-15 21:34 ` [PATCH] describe: output tag's ref instead of embedded name Matheus Tavares
2020-02-16 6:51 ` Jeff King
2020-02-18 19:31 ` Junio C Hamano
2020-02-18 19:54 ` Jeff King
2020-02-18 23:05 ` Junio C Hamano
2020-02-18 23:28 ` Junio C Hamano
2020-02-19 1:57 ` Jeff King
2020-02-19 3:22 ` Junio C Hamano
2020-02-19 3:56 ` Jeff King
2020-02-19 11:14 ` Junio C Hamano
2020-02-20 11:25 ` Jeff King
2020-02-20 17:34 ` Junio C Hamano
2020-02-20 22:19 ` Matheus Tavares Bernardino
2020-02-20 22:59 ` Junio C Hamano
2020-02-21 1:33 ` Matheus Tavares
2020-02-21 2:05 ` Junio C Hamano
2020-02-21 6:00 ` Jeff King [this message]
2020-02-21 5:58 ` Jeff King
2020-02-19 10:08 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221060029.GF1280313@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matheus.bernardino@usp.br \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).