From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6EE401F45E for ; Tue, 18 Feb 2020 19:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbgBRTzd (ORCPT ); Tue, 18 Feb 2020 14:55:33 -0500 Received: from cloud.peff.net ([104.130.231.41]:47108 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726283AbgBRTzc (ORCPT ); Tue, 18 Feb 2020 14:55:32 -0500 Received: (qmail 19946 invoked by uid 109); 18 Feb 2020 19:55:32 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 18 Feb 2020 19:55:32 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 21994 invoked by uid 111); 18 Feb 2020 20:04:32 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 18 Feb 2020 15:04:32 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 18 Feb 2020 14:55:31 -0500 From: Jeff King To: Junio C Hamano Cc: Taylor Blau , git@vger.kernel.org Subject: Re: [PATCH v2 06/15] rev-list: make --count work with --objects Message-ID: <20200218195531.GA21774@coredump.intra.peff.net> References: <20200214182147.GA654525@coredump.intra.peff.net> <20200214182220.GF150965@coredump.intra.peff.net> <20200215004216.GA15192@syl.local> <20200215064818.GB1633703@coredump.intra.peff.net> <20200218052438.GB1641086@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Feb 18, 2020 at 09:28:31AM -0800, Junio C Hamano wrote: > >> I think the question reader had was "why *right*?" > > > > Ah. The answer is: because it's not SYMMETRIC_LEFT. ;) > > > > The counting code accumulates there by default when there are no side > > markings, so that's what it will report when there's no left_right or > > cherry_mark (which we know will be the case here, since we die() > > otherwise). > > Yup. > > /* > * The object count is always accumulated in the .count_right > * field for traversal that is not a left-right traversal, > * and cmd_rev_list() made sure that a .count request that > * wants to count non-commit objects, which is handled by > * the show_object() callback, does not ask for .left_right. > */ > > Overkill? I dunno. No, I think it looks good. Want to squash that in (and I'll do likewise locally)? -Peff