From: Jeff King <email@example.com>
To: Drew DeVault <firstname.lastname@example.org>
Cc: email@example.com, Stefan Beller <firstname.lastname@example.org>,
Junio C Hamano <email@example.com>
Subject: Re: [PATCH 1/2] git-receive-pack: document push options
Date: Tue, 18 Feb 2020 00:30:40 -0500 [thread overview]
Message-ID: <20200218053040.GC1641086@coredump.intra.peff.net> (raw)
On Mon, Feb 17, 2020 at 09:44:31AM -0500, Drew DeVault wrote:
> Documentation/git-receive-pack.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/Documentation/git-receive-pack.txt b/Documentation/git-receive-pack.txt
> index 25702ed730..69b3e77776 100644
> --- a/Documentation/git-receive-pack.txt
> +++ b/Documentation/git-receive-pack.txt
> @@ -109,6 +109,12 @@ the following environment variables:
> This hook is called before any refname is updated and before any
> fast-forward checks are performed.
> +If the user has specified any push options (see linkgit:git-push),
> +`GIT_PUSH_OPTION_COUNT` is set to the number of options, and
> +`GIT_PUSH_OPTION_N` is set where N is an integer from 0 thru
> +`GIT_PUSH_OPTION_COUNT` - 1. In order for to receive push options,
> +`receive.advertisePushOptions` must be enabled on the server.
Hmm. This is covered already in the pre-receive sections of githooks(7).
I wonder if it would be worth consolidating those and having one refer
to the other.
I'd be OK just duplicating the content in the meantime, but note that
the githooks version covers some more subtleties (like setting the count
to 0 when push options are negotiated but none are sent).
If we do go with the text above, there's a typo: s/for to/to/.
prev parent reply other threads:[~2020-02-18 5:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 14:44 [PATCH 1/2] git-receive-pack: document push options Drew DeVault
2020-02-17 14:44 ` [PATCH 2/2] send-pack: downgrade push options error to warning Drew DeVault
2020-02-18 5:40 ` Jeff King
2020-02-18 17:44 ` Junio C Hamano
2020-02-18 5:30 ` Jeff King [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).