mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Drew DeVault <>
To:, Stefan Beller <>,
	Junio C Hamano <>
Cc: Drew DeVault <>
Subject: [PATCH 2/2] send-pack: downgrade push options error to warning
Date: Mon, 17 Feb 2020 09:44:32 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Because the receiving end has to explicitly enable
receive.advertisePushOptions, and many servers don't, it doesn't make
sense to set push options globally when half of your pushes are just
going to die.

Signed-off-by: Drew DeVault <>
 send-pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/send-pack.c b/send-pack.c
index 0407841ae8..8c81825e7d 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -439,7 +439,7 @@ int send_pack(struct send_pack_args *args,
 	use_atomic = atomic_supported && args->atomic;
 	if (args->push_options && !push_options_supported)
-		die(_("the receiving end does not support push options"));
+		warning(_("the receiving end does not support push options"));
 	use_push_options = push_options_supported && args->push_options;

  reply	other threads:[~2020-02-17 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 14:44 [PATCH 1/2] git-receive-pack: document push options Drew DeVault
2020-02-17 14:44 ` Drew DeVault [this message]
2020-02-18  5:40   ` [PATCH 2/2] send-pack: downgrade push options error to warning Jeff King
2020-02-18 17:44     ` Junio C Hamano
2020-02-18  5:30 ` [PATCH 1/2] git-receive-pack: document push options Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).