git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Miriam Rubio <mirucam@gmail.com>
To: git@vger.kernel.org
Cc: Pranit Bauva <pranit.bauva@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Tanushree Tumane <tanushreetumane@gmail.com>,
	Miriam Rubio <mirucam@gmail.com>
Subject: [PATCH v4 06/12] bisect--helper: return error codes from `cmd_bisect__helper()`
Date: Mon, 17 Feb 2020 09:40:33 +0100	[thread overview]
Message-ID: <20200217084039.78215-7-mirucam@gmail.com> (raw)
In-Reply-To: <20200217084039.78215-1-mirucam@gmail.com>

From: Pranit Bauva <pranit.bauva@gmail.com>

Since we want to get rid of git-bisect.sh, it would be necessary
to convert bisect.c exit() calls to return statements so
that errors can be reported. Let's prepare for that by making
it possible to return different error codes than just 0 or 1.

Different error codes might enable a bisecting script calling the
bisect command that uses this function to do different things
depending on the exit status of the bisect command.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
 builtin/bisect--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index e21d3d1a4c..e6bd4d6645 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -713,5 +713,5 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 		return error("BUG: unknown subcommand '%d'", cmdmode);
 	}
 	free_terms(&terms);
-	return !!res;
+	return abs(res);
 }
-- 
2.25.0


  parent reply	other threads:[~2020-02-17  8:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17  8:40 [Outreachy] [PATCH v4 00/12] Finish converting git bisect to C part 1 Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 01/12] bisect--helper: convert `vocab_*` char pointers to char arrays Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 02/12] bisect--helper: change `retval` to `res` Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 03/12] bisect: use the standard 'if (!var)' way to check for 0 Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 04/12] bisect--helper: introduce new `decide_next()` function Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 05/12] bisect: add enum to represent bisect returning codes Miriam Rubio
2020-02-17  8:40 ` Miriam Rubio [this message]
2020-02-17  8:40 ` [PATCH v4 07/12] bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` and its dependents Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 08/12] bisect: libify `bisect_checkout` Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 09/12] bisect: libify `check_merge_bases` and its dependents Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 10/12] bisect: libify `check_good_are_ancestors_of_bad` " Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 11/12] bisect: libify `handle_bad_merge_base` " Miriam Rubio
2020-02-17  8:40 ` [PATCH v4 12/12] bisect: libify `bisect_next_all` Miriam Rubio
2020-02-19 17:40 ` [Outreachy] [PATCH v4 00/12] Finish converting git bisect to C part 1 Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200217084039.78215-7-mirucam@gmail.com \
    --to=mirucam@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=pranit.bauva@gmail.com \
    --cc=tanushreetumane@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).