From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 06/15] rev-list: make --count work with --objects
Date: Sat, 15 Feb 2020 01:48:18 -0500 [thread overview]
Message-ID: <20200215064818.GB1633703@coredump.intra.peff.net> (raw)
In-Reply-To: <20200215004216.GA15192@syl.local>
On Fri, Feb 14, 2020 at 04:42:16PM -0800, Taylor Blau wrote:
> On Fri, Feb 14, 2020 at 01:22:20PM -0500, Jeff King wrote:
> > The current behavior from "rev-list --count --objects" is nonsensical:
> > we enumerate all of the objects except commits, but then give a count of
> > commits. This wasn't planned, and is just what the code happens to do.
> >
> > Instead, let's give the answer the user almost certainly wanted: the
> > full count of objects.
>
> This makes sense: I've often worried about introducing
> backwards-incompatible changes in newer versions of Git, even for
> behavior that didn't make sense to begin with.
>
> Of course, backwards-incompatible changes *are* something worth worrying
> about, but I don't find that the behavior was sensible to begin with, so
> I don't have a problem "breaking" it if "breaking" means making
> something nonsensical behave correctly.
Yeah, I admit I'm guessing that nobody cares about the current behavior,
or that it was unplanned. But it seems sufficiently insane to me to take
a chance on.
> > + if (revs->count) {
> > + revs->count_right++;
> > + return;
> > + }
> > +
>
> Hmm. This puzzled me at first. Do you think that it could benefit from a
> comment?
What would it say (i.e., I'm not sure what confused you)?
-Peff
next prev parent reply other threads:[~2020-02-15 6:48 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 2:15 [PATCH 0/13] combining object filters and bitmaps Jeff King
2020-02-13 2:16 ` [PATCH 01/13] pack-bitmap: factor out type iterator initialization Jeff King
2020-02-13 17:45 ` Junio C Hamano
2020-02-13 2:16 ` [PATCH 02/13] pack-bitmap: fix leak of haves/wants object lists Jeff King
2020-02-13 18:12 ` Junio C Hamano
2020-02-13 2:17 ` [PATCH 03/13] rev-list: fallback to non-bitmap traversal when filtering Jeff King
2020-02-13 18:19 ` Junio C Hamano
2020-02-13 18:40 ` Jeff King
2020-02-13 2:17 ` [PATCH 04/13] rev-list: consolidate bitmap-disabling options Jeff King
2020-02-13 2:18 ` [PATCH 05/13] rev-list: factor out bitmap-optimized routines Jeff King
2020-02-13 18:34 ` Junio C Hamano
2020-02-13 2:19 ` [PATCH 06/13] rev-list: make --count work with --objects Jeff King
2020-02-13 19:14 ` Junio C Hamano
2020-02-13 20:27 ` Jeff King
2020-02-13 2:20 ` [PATCH 07/13] rev-list: allow bitmaps when counting objects Jeff King
2020-02-13 21:47 ` Junio C Hamano
2020-02-13 22:27 ` Jeff King
2020-02-13 2:20 ` [PATCH 08/13] pack-bitmap: basic noop bitmap filter infrastructure Jeff King
2020-02-13 2:21 ` [PATCH 09/13] rev-list: use bitmap filters for traversal Jeff King
2020-02-13 22:22 ` Junio C Hamano
2020-02-13 22:34 ` Jeff King
2020-02-13 2:21 ` [PATCH 10/13] bitmap: add bitmap_unset() function Jeff King
2020-02-13 2:23 ` [PATCH 11/13] pack-bitmap: implement BLOB_NONE filtering Jeff King
2020-02-13 2:25 ` [PATCH 12/13] pack-bitmap: implement BLOB_LIMIT filtering Jeff King
2020-02-13 23:17 ` Junio C Hamano
2020-02-13 2:25 ` [PATCH 13/13] pack-objects: support filters with bitmaps Jeff King
2020-02-14 18:21 ` [PATCH v2 0/15] combining object filters and bitmaps Jeff King
2020-02-14 18:22 ` [PATCH v2 01/15] pack-bitmap: factor out type iterator initialization Jeff King
2020-02-15 0:10 ` Taylor Blau
2020-02-14 18:22 ` [PATCH v2 02/15] pack-bitmap: fix leak of haves/wants object lists Jeff King
2020-02-15 0:15 ` Taylor Blau
2020-02-15 6:46 ` Jeff King
2020-02-18 17:58 ` Derrick Stolee
2020-02-18 20:02 ` Jeff King
2020-02-14 18:22 ` [PATCH v2 03/15] rev-list: fallback to non-bitmap traversal when filtering Jeff King
2020-02-15 0:22 ` Taylor Blau
2020-02-14 18:22 ` [PATCH v2 04/15] pack-bitmap: refuse to do a bitmap traversal with pathspecs Jeff King
2020-02-14 19:03 ` Junio C Hamano
2020-02-14 20:51 ` Jeff King
2020-02-14 18:22 ` [PATCH v2 05/15] rev-list: factor out bitmap-optimized routines Jeff King
2020-02-15 0:35 ` Taylor Blau
2020-02-14 18:22 ` [PATCH v2 06/15] rev-list: make --count work with --objects Jeff King
2020-02-15 0:42 ` Taylor Blau
2020-02-15 6:48 ` Jeff King [this message]
2020-02-16 23:34 ` Junio C Hamano
2020-02-18 5:24 ` Jeff King
2020-02-18 17:28 ` Junio C Hamano
2020-02-18 19:55 ` Jeff King
2020-02-18 21:19 ` Junio C Hamano
2020-02-18 21:23 ` Jeff King
2020-02-18 18:05 ` Derrick Stolee
2020-02-18 19:59 ` Jeff King
2020-02-14 18:22 ` [PATCH v2 07/15] rev-list: allow bitmaps when counting objects Jeff King
2020-02-15 0:45 ` Taylor Blau
2020-02-15 6:55 ` Jeff King
2020-02-16 23:36 ` Junio C Hamano
2020-02-14 18:22 ` [PATCH v2 08/15] t5310: factor out bitmap traversal comparison Jeff King
2020-02-15 2:14 ` Taylor Blau
2020-02-15 7:00 ` Jeff King
2020-02-14 18:22 ` [PATCH v2 09/15] rev-list: allow commit-only bitmap traversals Jeff King
2020-02-18 18:18 ` Derrick Stolee
2020-02-18 20:05 ` Jeff King
2020-02-18 20:11 ` Derrick Stolee
2020-02-14 18:22 ` [PATCH v2 10/15] pack-bitmap: basic noop bitmap filter infrastructure Jeff King
2020-02-14 18:22 ` [PATCH v2 11/15] rev-list: use bitmap filters for traversal Jeff King
2020-02-14 18:22 ` [PATCH v2 12/15] bitmap: add bitmap_unset() function Jeff King
2020-02-14 18:22 ` [PATCH v2 13/15] pack-bitmap: implement BLOB_NONE filtering Jeff King
2020-02-18 19:26 ` Derrick Stolee
2020-02-18 19:36 ` Derrick Stolee
2020-02-18 20:30 ` Jeff King
2020-02-18 20:24 ` Jeff King
2020-02-14 18:22 ` [PATCH v2 14/15] pack-bitmap: implement BLOB_LIMIT filtering Jeff King
2020-02-14 18:22 ` [PATCH v2 15/15] pack-objects: support filters with bitmaps Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200215064818.GB1633703@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).