From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 08B8F1F45E for ; Thu, 13 Feb 2020 11:48:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729772AbgBMLsG (ORCPT ); Thu, 13 Feb 2020 06:48:06 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36020 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729544AbgBMLsF (ORCPT ); Thu, 13 Feb 2020 06:48:05 -0500 Received: by mail-wr1-f66.google.com with SMTP id z3so6306119wru.3 for ; Thu, 13 Feb 2020 03:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zvQsEh5/Pd9v1AWSdyD5z9b+EpkkjinSiSfi3dXoSBk=; b=vOugaSbrIAOnFPMbF8annJfMvEmHEcj6leq+Cyqrgjvjnvra2rrh2ft7466t4P4y3V P33kyh0Yjjrvm4BrAPL+OL4eNlK+A9WYOES+eiIS4kJXhpMqyUaFo+AXXiIjihAOSsR7 CFpo4bbsDCd13TbdBnNI3dILPsSESwJAzaPIeI/4lLpGFlUm9hcHH1w8ao7aURRjUM5O 0FQLfVozfadV19HY9kS0SGlDgJOKLzL0RDVGbhq9+Zz61ZZdWPz0nz/sgrk+NA3MMUZ0 3/XCr6Lgg1brvl+a0b265BDQoCH0S8GF/AABTDNl81aZEbLhiRLcSe77FjUnAljvXxZS CXuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zvQsEh5/Pd9v1AWSdyD5z9b+EpkkjinSiSfi3dXoSBk=; b=nHUNM2KntTyKEmK6HBhosgoQIpCw1/wfuGYoyepG1lAfkuHDBMp1f6X7Yan5QHIrKN y7zXG8qkecNnuxdy8wu0ds2ANhr45LVPdrB0AR8tfiSB5FuQgqKT6FiU615Uu3G2XNYb Y+gLurdSFCq2qGkCPSO6n9i37Dwl+DYNEqaiac0bJgY76QU+b+SJnFEz7Ometwd3fpa3 ny2MrJFI1WWUDKHc+LCIrEaz0GwwQya3pzK75wwG4YOOfTQ3qxrDb3kUqZSEBXk90o7I InWsGCbpSTQ+TDdEHSAL5hYXE5zj9hBE5IGTOsglD8kCT65qyIMS1VAlitklvIcXfog2 tNtw== X-Gm-Message-State: APjAAAV2fnZ/tvOYHrvuF+qCPrsVXb09lj+um2n1nNmujKzjkQxrROq1 nhTnpnJiqn8y+hFkJ5NqtRs= X-Google-Smtp-Source: APXvYqwKDXxnIZ8pT6CdtjzjzxdtpLjrZOViO6xLyKfa2sBHHP8P+eSbaQmSZnOILB4npRt8dRYOfw== X-Received: by 2002:adf:a381:: with SMTP id l1mr21323206wrb.102.1581594482944; Thu, 13 Feb 2020 03:48:02 -0800 (PST) Received: from szeder.dev (x4dbd7231.dyn.telefonica.de. [77.189.114.49]) by smtp.gmail.com with ESMTPSA id g21sm2581761wmh.17.2020.02.13.03.48.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Feb 2020 03:48:02 -0800 (PST) Date: Thu, 13 Feb 2020 12:48:00 +0100 From: SZEDER =?utf-8?B?R8OhYm9y?= To: Taylor Blau Cc: Martin =?utf-8?B?w4VncmVu?= , Git Mailing List , Jeff King , Derrick Stolee , Junio C Hamano Subject: Re: [PATCH 2/3] builtin/commit-graph.c: introduce '--input=' Message-ID: <20200213114800.GP10482@szeder.dev> References: <8effe35bcd1dadee3a29d996f269353cf6e4982d.1580430057.git.me@ttaylorr.com> <20200204045124.GG5790@syl.local> <20200213113313.GO10482@szeder.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200213113313.GO10482@szeder.dev> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Feb 13, 2020 at 12:33:13PM +0100, SZEDER Gábor wrote: > On Mon, Feb 03, 2020 at 08:51:24PM -0800, Taylor Blau wrote: > > On Fri, Jan 31, 2020 at 08:34:41PM +0100, Martin Ågren wrote: > > > On Fri, 31 Jan 2020 at 01:30, Taylor Blau wrote: > > > > The 'write' mode of the 'commit-graph' supports input from a number of > > s/mode/subcommand/ > > > > > different sources: > > I note that you use the word "sources" here, in the subject line as > well (as '--input='), and in the code as well (e.g. the in > the error message "unrecognized --input source, %s"). I like this > word, I think the words "input" and "source" go really well together. > > > > > pack indexes over stdin, commits over stdin, commits > > > > reachable from all references, and so on. > > It's interesting to see that you stopped listing and went for "and so > on" right when it got interesting/controversial with '--append'... :) > > > > > Each of these options are > > > > specified with a unique option: '--stdin-packs', '--stdin-commits', etc. > > It also supports the very inefficient scanning through all objects in > all pack files to find commit objects, which, sadly, ended up being > the default, and thus doesn't have its own --option. Should there be > a corresponding '--input=' as well? (Note that I don't mean > this as a suggestion to add one; on the contrary, the less exposure it > gets the better.) > > > > > Similar to our replacement of 'git config [--]' with 'git config > > > > [--type=]' (c.f., fb0dc3bac1 (builtin/config.c: support > > > > `--type=` as preferred alias for `--`, 2018-04-18)), softly > > > > deprecate '[--]' in favor of '[--input=]'. > > > > > > > > This makes it more clear to implement new options that are combinations > > > > of other options (such as, for example, "none", a combination of the old > > > > "--append" and a new sentinel to specify to _not_ look in other packs, > > > > which we will implement in a future patch). > > > > > > Makes sense. > > > > > > > Unfortunately, the new enumerated type is a bitfield, even though it > > > > makes much more sense as '0, 1, 2, ...'. Even though *almost* all > > > > options are pairwise exclusive, '--stdin-{packs,commits}' *is* > > > > compatible with '--append'. For this reason, use a bitfield. > > > > > > > -With the `--append` option, include all commits that are present in the > > > > -existing commit-graph file. > > > > +With the `--input=append` option, include all commits that are present > > > > +in the existing commit-graph file. > > > > > > Would it be too crazy to call this `--input=existing` instead, and have > > > it be the same as `--append`? I find that `--append` makes a lot of > > > sense (it's a mode we can turn on or off), whereas "input = append" > > > seems more odd. > > > > Hmm. When I wrote this, I was thinking of introducing equivalent options > > that are identical in name and functionality as '--input=' instead > > of '--'. So, I guess that is to say that I didn't spend an awful > > amount of time thinking about whether or not '--input=append' made sense > > given anything else. > > > > So, I don't think that '--input=existing' is a bad idea at all, but I do > > worry about advertising this deprecation as "'--' becomes > > '--input=', except when your mode is 'append', in which case it > > becomes '--input=existing'". > > But here you suddenly start using the word "mode" both in > '--input=' and in '--'. > > On one hand, I don't think that the word "mode" goes as well with > "input" as "source" does. > > On the other, is '--append' really a source/mode, like '--reachable' > and '--stdin-commits' are? Well, re-reading this question got me confused right after sending it, so let me try to rephrase. Is '--append' really a "source", like '--reachable' and '--stdin-commits' are? No: > Source, no: from wordsmithing perspective > it doesn't fit with "source", and being orthogonal to the "real" > source options while they are mutually exclusive seems to be a clear > indication that it isn't. Or is it a "mode" modifying how other options are handled? Yes: > Mode, yes: it's a mode of operation where > no longer reachable/present commits are not discarded from the > commit-graph. > > So I don't think that adding '--input=append' is a good idea, even if > we were call it differently, e.g. '--input=existing' as suggested > above. > > However, I do think that '--input=existing' would better express what > '--input=none' in the next patch wants to achieve. >